From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ricardo Neri <ricardo.neri@ti.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"Girdwood, Liam" <lrg@ti.com>,
"lrg@slimlogic.co.uk" <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 4/6] ASoC: OMAP: Add CPU DAI driver for HDMI
Date: Fri, 6 May 2011 14:21:33 +0100 [thread overview]
Message-ID: <20110506132133.GM23729@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1304624105.1900.41.camel@sagan>
On Thu, May 05, 2011 at 02:35:05PM -0500, Ricardo Neri wrote:
> Am Donnerstag, den 05.05.2011, 03:22 -0500 schrieb Mark Brown:
> > dev_er(). Also, why are you checking this, and are you checking it too
> > early?
> I will replace with dev_err(). I need to check if HDMI display is active
> because the HDMI DSS driver is in charge of powering on/off the HDMI IP.
> Audio can play only if the HDMI IP is on. I don't have a .trigger
> function in my DAI so I thought it was OK to perform the check
> at .startup. Do you think I should create a .trigger function and
> perform the check from there?
Why do you need to check at all? The playback won't work when the
output isn't connected but the application layer will find that out when
there's no data transfer anyway. If you implement the check in startup
I'd imagine there may be some races with hotplug of HDMI cables.
next prev parent reply other threads:[~2011-05-06 13:21 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 7:21 [PATCH 0/6] ASoC: OMAP4: Add support for HDMI audio Ricardo Neri
2011-05-05 7:21 ` [PATCH 1/6] OMAP4: HDMI: Add OMAP device for HDMI audio CPU DAI Ricardo Neri
2011-05-05 8:17 ` Mark Brown
2011-05-05 19:24 ` Ricardo Neri
2011-05-06 13:16 ` Mark Brown
2011-05-08 0:09 ` Ricardo Neri
2011-05-05 7:21 ` [PATCH 2/6] OMAP4: Add device for HDMI OMAP4 audio for ASoC machine driver Ricardo Neri
2011-05-05 8:18 ` Mark Brown
2011-05-05 19:26 ` Ricardo Neri
2011-05-05 7:21 ` [PATCH 3/6] ASoC: OMAP: Add header for HDMI CPU DAI Ricardo Neri
2011-05-05 8:25 ` Mark Brown
2011-05-05 21:10 ` Ricardo Neri
2011-05-05 7:21 ` [PATCH 4/6] ASoC: OMAP: Add CPU DAI driver for HDMI Ricardo Neri
2011-05-05 8:22 ` Mark Brown
2011-05-05 19:35 ` Ricardo Neri
2011-05-06 13:21 ` Mark Brown [this message]
2011-05-08 0:05 ` Ricardo Neri
2011-05-08 10:34 ` Mark Brown
2011-05-08 11:14 ` Liam Girdwood
2011-05-08 15:56 ` Mark Brown
2011-05-08 19:44 ` Liam Girdwood
2011-05-08 23:41 ` Mark Brown
2011-05-12 13:48 ` Neri, Ricardo
2011-05-05 7:21 ` [PATCH 5/6] ASoC: OMAP4: Add HDMI Audio machine driver for OMAP4 boards Ricardo Neri
2011-05-05 8:25 ` Mark Brown
2011-05-05 21:09 ` Ricardo Neri
2011-05-06 13:22 ` Mark Brown
2011-05-05 7:21 ` [PATCH 6/6] ASoC: OMAP: Update Makefile and Kconfig for HDMI audio Ricardo Neri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110506132133.GM23729@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=lrg@ti.com \
--cc=ricardo.neri@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).