From: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH 7/7] ASoC: soc-cache: Introduce raw bulk write support
Date: Wed, 11 May 2011 10:20:29 +0100 [thread overview]
Message-ID: <20110511092029.GA13823@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20110510211317.GB17589@sirena.org.uk>
On Tue, May 10, 2011 at 10:13:18PM +0100, Mark Brown wrote:
> On Tue, Mar 22, 2011 at 10:37:03AM +0000, Dimitris Papastamos wrote:
>
> > + switch (codec->control_type) {
> > + case SND_SOC_I2C:
> > + ret = i2c_master_send(codec->control_data, data, len);
> > + break;
> > + case SND_SOC_SPI:
> > + ret = do_spi_write(codec->control_data, data, len);
> > + break;
>
> Hrm, I now realise that this doesn't actually do what I'd expect - it
> only writes out the provided data, there's no inclusion of the register
> address. I'd been mislead by the fact that it is taking in the register
> address as an argument and an overly hasty review it seems. That's a
> little too raw for me, we should be prefixing the data with the base
> register address.
Yes, I was going to send a patch for this because I need it for syncing the
block based rbtree cache.
next prev parent reply other threads:[~2011-05-11 9:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-22 10:36 [PATCH 1/7] ASoC: Add control_type in snd_soc_codec Dimitris Papastamos
2011-03-22 10:36 ` [PATCH 2/7] ASoC: soc-cache: Factor-out the hw_write() specific code Dimitris Papastamos
2011-03-22 10:36 ` [PATCH 3/7] ASoC: soc-cache: Factor-out the hw_read() " Dimitris Papastamos
2011-03-22 10:37 ` [PATCH 4/7] ASoC: soc-cache: Factor-out the SPI write code Dimitris Papastamos
2011-03-22 10:37 ` [PATCH 5/7] ASoC: soc-cache: Factor-out the I2C read code Dimitris Papastamos
2011-03-22 10:37 ` [PATCH 6/7] ASoC: soc-cache: Fix indentation issues Dimitris Papastamos
2011-03-26 17:40 ` Mark Brown
2011-03-22 10:37 ` [PATCH 7/7] ASoC: soc-cache: Introduce raw bulk write support Dimitris Papastamos
2011-05-10 21:13 ` Mark Brown
2011-05-11 9:20 ` Dimitris Papastamos [this message]
2011-03-26 12:59 ` [PATCH 1/7] ASoC: Add control_type in snd_soc_codec Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110511092029.GA13823@opensource.wolfsonmicro.com \
--to=dp@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@ti.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).