* [PATCH 7/9] ASoC: Silence DEBUG_STRICT_USER_COPY_CHECKS=y warning [not found] <1305244212-19183-1-git-send-email-sboyd@codeaurora.org> @ 2011-05-12 23:50 ` Stephen Boyd 2011-05-16 16:26 ` Liam Girdwood 2011-05-16 20:22 ` Mark Brown 0 siblings, 2 replies; 3+ messages in thread From: Stephen Boyd @ 2011-05-12 23:50 UTC (permalink / raw) To: alsa-devel Cc: linux-kernel, Jaroslav Kysela, Takashi Iwai, Liam Girdwood, Mark Brown Enabling DEBUG_STRICT_USER_COPY_CHECKS causes the following warning: In file included from arch/x86/include/asm/uaccess.h:573, from include/linux/poll.h:14, from include/sound/pcm.h:29, from include/sound/ac97_codec.h:31, from sound/soc/soc-core.c:34: In function 'copy_from_user', inlined from 'codec_reg_write_file' at sound/soc/soc-core.c:252: arch/x86/include/asm/uaccess_64.h:65: warning: call to 'copy_from_user_overflow' declared with attribute warning: copy_from_user() buffer size is not provably correct presumably due to buf_size being signed causing GCC to fail to see that buf_size can't become negative. Cc: Liam Girdwood <lrg@slimlogic.co.uk> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> --- sound/soc/soc-core.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index d8562ce..e8a0f64 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -242,7 +242,7 @@ static ssize_t codec_reg_write_file(struct file *file, const char __user *user_buf, size_t count, loff_t *ppos) { char buf[32]; - int buf_size; + size_t buf_size; char *start = buf; unsigned long reg, value; int step = 1; -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 7/9] ASoC: Silence DEBUG_STRICT_USER_COPY_CHECKS=y warning 2011-05-12 23:50 ` [PATCH 7/9] ASoC: Silence DEBUG_STRICT_USER_COPY_CHECKS=y warning Stephen Boyd @ 2011-05-16 16:26 ` Liam Girdwood 2011-05-16 20:22 ` Mark Brown 1 sibling, 0 replies; 3+ messages in thread From: Liam Girdwood @ 2011-05-16 16:26 UTC (permalink / raw) To: Stephen Boyd; +Cc: alsa-devel, Takashi Iwai, Mark Brown, linux-kernel, Jaroslav On Thu, 2011-05-12 at 16:50 -0700, Stephen Boyd wrote: > Enabling DEBUG_STRICT_USER_COPY_CHECKS causes the following > warning: > > In file included from arch/x86/include/asm/uaccess.h:573, > from include/linux/poll.h:14, > from include/sound/pcm.h:29, > from include/sound/ac97_codec.h:31, > from sound/soc/soc-core.c:34: > In function 'copy_from_user', > inlined from 'codec_reg_write_file' at > sound/soc/soc-core.c:252: > arch/x86/include/asm/uaccess_64.h:65: > warning: call to 'copy_from_user_overflow' declared with > attribute warning: copy_from_user() buffer size is not provably > correct > > presumably due to buf_size being signed causing GCC to fail to > see that buf_size can't become negative. > > Cc: Liam Girdwood <lrg@slimlogic.co.uk> > Cc: Mark Brown <broonie@opensource.wolfsonmicro.com> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> Acked-by: Liam Girdwood <lrg@ti.com> ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 7/9] ASoC: Silence DEBUG_STRICT_USER_COPY_CHECKS=y warning 2011-05-12 23:50 ` [PATCH 7/9] ASoC: Silence DEBUG_STRICT_USER_COPY_CHECKS=y warning Stephen Boyd 2011-05-16 16:26 ` Liam Girdwood @ 2011-05-16 20:22 ` Mark Brown 1 sibling, 0 replies; 3+ messages in thread From: Mark Brown @ 2011-05-16 20:22 UTC (permalink / raw) To: Stephen Boyd; +Cc: Takashi Iwai, alsa-devel, Liam Girdwood, linux-kernel On Thu, May 12, 2011 at 04:50:10PM -0700, Stephen Boyd wrote: > Enabling DEBUG_STRICT_USER_COPY_CHECKS causes the following > warning: Applied, thanks. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-07-27 12:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1305244212-19183-1-git-send-email-sboyd@codeaurora.org>
2011-05-12 23:50 ` [PATCH 7/9] ASoC: Silence DEBUG_STRICT_USER_COPY_CHECKS=y warning Stephen Boyd
2011-05-16 16:26 ` Liam Girdwood
2011-05-16 20:22 ` Mark Brown
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).