From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Taylor Hutt <thutt@chromium.org>
Cc: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>,
linux-kernel@vger.kernel.org,
Peter Hsiang <peter.hsiang@maxim-ic.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] Max98095: Move existing NULL check before pointer dereference.
Date: Wed, 18 May 2011 09:38:19 -0700 [thread overview]
Message-ID: <20110518163819.GD16414@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1305680634-10484-1-git-send-email-thutt@chromium.org>
On Tue, May 17, 2011 at 06:03:54PM -0700, Taylor Hutt wrote:
> Visual inspection shows that max98095_put_eq_enum() and
> max98095_put_bq_enum() each have a possible NULL deref of 'pdata'.
>
> This change moves the NULL check above the use.
Applied, thanks. Please try to keep your subject line consistent with
the rest of the subsystem.
prev parent reply other threads:[~2011-05-18 16:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 1:03 [PATCH] Max98095: Move existing NULL check before pointer dereference Taylor Hutt
2011-05-18 1:28 ` Peter Hsiang
2011-05-18 7:06 ` Mark Brown
2011-05-18 13:53 ` Peter Hsiang
2011-05-18 9:32 ` Liam Girdwood
2011-05-18 16:38 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110518163819.GD16414@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=peter.hsiang@maxim-ic.com \
--cc=thutt@chromium.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).