From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] ASoC: tlv320aic3x: Add correct hw registers to Line1 cross connect muxes
Date: Thu, 26 May 2011 22:07:55 +0800 [thread overview]
Message-ID: <20110526140754.GC15094@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1306399022-4490-1-git-send-email-jhnikula@gmail.com>
On Thu, May 26, 2011 at 11:37:02AM +0300, Jarkko Nikula wrote:
> Commit af46800 ("ASoC: Implement mux control sharing") revealed that
> "Left Line1[L | R] Mux" and "Right Line1[L | R] Mux" widgets were pointing
> to the same kcontrols and codec registers and thus soc-core falsely detected
> them as shared controls. This is actually wrong since there are separate
> registers in hardware that configure Line1L to RADC and Line1R to LADC cross
> connects so these muxes should not be shared.
>
> Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
prev parent reply other threads:[~2011-05-26 14:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 8:37 [PATCH] ASoC: tlv320aic3x: Add correct hw registers to Line1 cross connect muxes Jarkko Nikula
2011-05-26 14:07 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110526140754.GC15094@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=jhnikula@gmail.com \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox