From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Caleb Crome <caleb@crome.org>
Cc: alsa-devel@alsa-project.org
Subject: Re: Proposed changes to soc core to allow multiple codecs bound together on a single bus
Date: Mon, 6 Jun 2011 11:51:15 +0100 [thread overview]
Message-ID: <20110606105115.GB12783@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <BANLkTimBmj+BROhu9b-+wQRXUQa6ABpOBQ@mail.gmail.com>
On Fri, Jun 03, 2011 at 05:04:12PM -0700, Caleb Crome wrote:
> static char *my_codec_dais[] = {
> "tlv320aic3x-hifi.0", <---- in this case, the '.0'
> "tlv320aic3x-hifi.1", ---- means that it's slot 0
> "tlv320aic3x-hifi.2", ---- on the TDM bus.
> "tlv320aic3x-hifi.3",
> };
> static char *my_codec_names[] = {
> "tlv320aic3x-codec.2-0018", <--- codec on i2c bus 2, addr 0x18
> "tlv320aic3x-codec.2-0019", <--- codec on i2c bus 2, addr 0x19
> "tlv320aic3x-codec.2-001a", <--- codec on i2c bus 2, addr 0x1a
> "tlv320aic3x-codec.2-001b", <--- codec on i2c bus 2, addr 0x1b
> };
I don't like the need to line the two arrays up, and the DAI names
really ought to be enough anyway (this applies in general, not just
here).
> The core will parse the dai name for the slot order, and pass it on to the
> codec during hw_params. Then the codec can properly set the TDM slot on the
> hardware interface.
No, the machine driver needs to own the TDM configuration. We need to
have the flexibiltiy for the system to use arbatrary arrangements for
things like buses with more than two devices on them and we need to be
able to cope with random layouts of the channels (for example, all the
left channels on one device, all the right channels on another device).
We also need to be able to change this dynamically at runtime depending
on the current needs of the system.
next prev parent reply other threads:[~2011-06-06 10:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-04 0:04 Proposed changes to soc core to allow multiple codecs bound together on a single bus Caleb Crome
2011-06-06 10:47 ` Liam Girdwood
2011-06-06 10:51 ` Mark Brown [this message]
2011-06-09 19:23 ` Caleb Crome
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110606105115.GB12783@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=caleb@crome.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).