From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Timur Tabi <timur@freescale.com>
Cc: ALSA development <alsa-devel@alsa-project.org>, lrg@ti.com
Subject: Re: Something broke in snd_soc_pcm_stream
Date: Wed, 8 Jun 2011 10:05:52 +0100 [thread overview]
Message-ID: <20110608090552.GB2828@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4DEEA429.6040605@freescale.com>
On Tue, Jun 07, 2011 at 05:20:25PM -0500, Timur Tabi wrote:
> It just so happens that on the the P1022, the CPU does support both directions
> in its DAI, but the codec (WM8776) supports only one direction per DAI. So I
> suspect that you shouldn't be testing codec_dai either, because it assumes that
> the codec is the only arbiter on which direction a given dai-group supports.
Or it just means that unidirectional CPU DAIs are so rare that nobody
got round to adding the check for them.
> Anyway, I changed my driver to test for the actual pointer, and it works. You
> might want to consider doing the same in soc_pcm_new().
I know we've been round this loop quite a few times in the past but just
to reiterate the situation with Linux is rather different to with other
OSs - you can submit patches to *any* code in Linux, you're not restricted
to only working on your individual driver.
prev parent reply other threads:[~2011-06-08 9:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-07 21:31 Something broke in snd_soc_pcm_stream Timur Tabi
2011-06-07 21:44 ` Mark Brown
2011-06-07 22:20 ` Timur Tabi
2011-06-08 9:05 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110608090552.GB2828@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@ti.com \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).