* Re: [PATCH 0/1] Submitting MAX98088 codec patch
[not found] <BANLkTikLubBnrPp0BTMcNEFp2sfAyZnE4A@mail.gmail.com>
@ 2011-06-09 10:47 ` Mark Brown
2011-06-09 13:51 ` Liam Girdwood
0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2011-06-09 10:47 UTC (permalink / raw)
To: Jin Park; +Cc: Peter.Hsiang, alsa-devel, Jassi Brar, lrg
On Thu, Jun 09, 2011 at 05:50:16PM +0900, Jin Park wrote:
> The max98088 codec driver had unnecessary duplicated codes on DAI operations.
> For example, max98088_dai1_hw_params and max98088_dai2_hw_params,
> they are almost same, except only register offsets.
> So I have combined DAI operations for DAI1 and DAI2.
> Please review my patch.
Note that there's no need to have a cover letter for a single patch -
any useful information should be in the patch itself.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 0/1] Submitting MAX98088 codec patch
2011-06-09 10:47 ` [PATCH 0/1] Submitting MAX98088 codec patch Mark Brown
@ 2011-06-09 13:51 ` Liam Girdwood
0 siblings, 0 replies; 2+ messages in thread
From: Liam Girdwood @ 2011-06-09 13:51 UTC (permalink / raw)
To: Mark Brown
Cc: Peter.Hsiang@maxim-ic.com, alsa-devel@alsa-project.org,
Jassi Brar, Jin Park, lrg@slimlogic.co.uk
On 09/06/11 11:47, Mark Brown wrote:
> On Thu, Jun 09, 2011 at 05:50:16PM +0900, Jin Park wrote:
>
>> The max98088 codec driver had unnecessary duplicated codes on DAI operations.
>> For example, max98088_dai1_hw_params and max98088_dai2_hw_params,
>> they are almost same, except only register offsets.
>> So I have combined DAI operations for DAI1 and DAI2.
>> Please review my patch.
>
> Note that there's no need to have a cover letter for a single patch -
> any useful information should be in the patch itself.
> _______________________________________________
>
Acked-by: Liam Girdwood <lrg@ti.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-06-09 13:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <BANLkTikLubBnrPp0BTMcNEFp2sfAyZnE4A@mail.gmail.com>
2011-06-09 10:47 ` [PATCH 0/1] Submitting MAX98088 codec patch Mark Brown
2011-06-09 13:51 ` Liam Girdwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).