From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 0/1] Submitting MAX98088 codec patch Date: Thu, 9 Jun 2011 11:47:58 +0100 Message-ID: <20110609104758.GC12865@opensource.wolfsonmicro.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id E9EDE1037F5 for ; Thu, 9 Jun 2011 12:47:59 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Jin Park Cc: Peter.Hsiang@maxim-ic.com, alsa-devel@alsa-project.org, Jassi Brar , lrg@slimlogic.co.uk List-Id: alsa-devel@alsa-project.org On Thu, Jun 09, 2011 at 05:50:16PM +0900, Jin Park wrote: > The max98088 codec driver had unnecessary duplicated codes on DAI operations. > For example, max98088_dai1_hw_params and max98088_dai2_hw_params, > they are almost same, except only register offsets. > So I have combined DAI operations for DAI1 and DAI2. > Please review my patch. Note that there's no need to have a cover letter for a single patch - any useful information should be in the patch itself.