alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Timur Tabi <timur@freescale.com>
Cc: alsa-devel@alsa-project.org, lrg@ti.com
Subject: Re: [PATCH 2/2] ASoC: fsl: fix initialization of DMA buffers
Date: Thu, 9 Jun 2011 11:52:46 +0100	[thread overview]
Message-ID: <20110609105246.GD12865@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1307563376-13055-2-git-send-email-timur@freescale.com>

On Wed, Jun 08, 2011 at 03:02:56PM -0500, Timur Tabi wrote:
> The DMA (PCM) driver used by some Freescale PowerPC supports separate DAIs
> for playback and capture, so DMA buffers should be allocated only for the
> initialized streams.  Instead of checking for the number of active channels,
> which apparently is not reliable, check to see if the actual stream object
> exists.

I'll apply this but...

> Also provide a better name for the DMA interrupt.

...this doesn't overlap with the bugfix at all.  Why have you sent it as
part of the same patch?

  reply	other threads:[~2011-06-09 10:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-08 20:02 [PATCH 1/2] ASoC: p1022ds: fix incorrect referencing of device tree properties Timur Tabi
2011-06-08 20:02 ` [PATCH 2/2] ASoC: fsl: fix initialization of DMA buffers Timur Tabi
2011-06-09 10:52   ` Mark Brown [this message]
2011-06-09 12:39     ` Tabi Timur-B04825
2011-06-08 22:06 ` [PATCH 1/2] ASoC: p1022ds: fix incorrect referencing of device tree properties Steve Calfee
2011-06-08 22:27   ` Timur Tabi
2011-06-09  9:45 ` Liam Girdwood
2011-06-09 11:01 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110609105246.GD12865@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=lrg@ti.com \
    --cc=timur@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).