From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Timur Tabi <timur@freescale.com>
Cc: alsa-devel@alsa-project.org, lrg@ti.com
Subject: Re: [PATCH 1/2] ASoC: p1022ds: fix incorrect referencing of device tree properties
Date: Thu, 9 Jun 2011 12:01:29 +0100 [thread overview]
Message-ID: <20110609110129.GE12865@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1307563376-13055-1-git-send-email-timur@freescale.com>
On Wed, Jun 08, 2011 at 03:02:55PM -0500, Timur Tabi wrote:
> Device tree integer properties are encoded in big-endian format, but some of
> the Freescale ASoC drivers were assuming that the host is in big-endian format
> as well. Although this is true, it's better to use endian-safe accessors.
>
> Also add a check for a failed ioremap() call in the SSI driver.
Similarly this patch appears to consist of two unrelated changes. I'll
apply this time but please don't do this in future.
Please also include non-urgent cleanups like this after bug fixes in your
patch serieses - while the bug fixes get applied to the release branch
new features and cleanups don't but ordering the cleanups first means
the bugfixes may end up depending on them.
prev parent reply other threads:[~2011-06-09 11:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 20:02 [PATCH 1/2] ASoC: p1022ds: fix incorrect referencing of device tree properties Timur Tabi
2011-06-08 20:02 ` [PATCH 2/2] ASoC: fsl: fix initialization of DMA buffers Timur Tabi
2011-06-09 10:52 ` Mark Brown
2011-06-09 12:39 ` Tabi Timur-B04825
2011-06-08 22:06 ` [PATCH 1/2] ASoC: p1022ds: fix incorrect referencing of device tree properties Steve Calfee
2011-06-08 22:27 ` Timur Tabi
2011-06-09 9:45 ` Liam Girdwood
2011-06-09 11:01 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110609110129.GE12865@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@ti.com \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).