public inbox for alsa-devel@alsa-project.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: Blackfin: allow SPI for SSM2602 parts
@ 2011-06-17  2:24 Mike Frysinger
  2011-06-17  8:04 ` Liam Girdwood
  2011-06-17  9:41 ` Mark Brown
  0 siblings, 2 replies; 4+ messages in thread
From: Mike Frysinger @ 2011-06-17  2:24 UTC (permalink / raw)
  To: alsa-devel, Liam Girdwood, Mark Brown; +Cc: uclinux-dist-devel

This board has hardware switches for selecting SPI or I2C, so don't
require I2C for this driver.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 sound/soc/blackfin/Kconfig |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/sound/soc/blackfin/Kconfig b/sound/soc/blackfin/Kconfig
index 4d361bd..871308f 100644
--- a/sound/soc/blackfin/Kconfig
+++ b/sound/soc/blackfin/Kconfig
@@ -10,10 +10,9 @@ config SND_BF5XX_I2S
 
 config SND_BF5XX_SOC_SSM2602
 	tristate "SoC SSM2602 Audio support for BF52x ezkit"
-	depends on SND_BF5XX_I2S
+	depends on SND_BF5XX_I2S && (SPI_MASTER || I2C)
 	select SND_BF5XX_SOC_I2S
 	select SND_SOC_SSM2602
-	select I2C
 	help
 	  Say Y if you want to add support for SoC audio on BF527-EZKIT.
 
-- 
1.7.5.3

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ASoC: Blackfin: allow SPI for SSM2602 parts
  2011-06-17  2:24 [PATCH] ASoC: Blackfin: allow SPI for SSM2602 parts Mike Frysinger
@ 2011-06-17  8:04 ` Liam Girdwood
  2011-06-17  9:41 ` Mark Brown
  1 sibling, 0 replies; 4+ messages in thread
From: Liam Girdwood @ 2011-06-17  8:04 UTC (permalink / raw)
  To: Mike Frysinger
  Cc: uclinux-dist-devel@blackfin.uclinux.org,
	alsa-devel@alsa-project.org, Mark Brown, Liam Girdwood

On 17/06/11 03:24, Mike Frysinger wrote:
> This board has hardware switches for selecting SPI or I2C, so don't
> require I2C for this driver.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---

Acked-by: Liam Girdwood <lrg@ti.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ASoC: Blackfin: allow SPI for SSM2602 parts
  2011-06-17  2:24 [PATCH] ASoC: Blackfin: allow SPI for SSM2602 parts Mike Frysinger
  2011-06-17  8:04 ` Liam Girdwood
@ 2011-06-17  9:41 ` Mark Brown
  2011-06-17 15:21   ` [uclinux-dist-devel] " Mike Frysinger
  1 sibling, 1 reply; 4+ messages in thread
From: Mark Brown @ 2011-06-17  9:41 UTC (permalink / raw)
  To: Mike Frysinger; +Cc: uclinux-dist-devel, alsa-devel, Liam Girdwood

On Thu, Jun 16, 2011 at 10:24:15PM -0400, Mike Frysinger wrote:
> This board has hardware switches for selecting SPI or I2C, so don't
> require I2C for this driver.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>

Applied, though I suspect this won't actually load as the different bus
will change the name the CODEC uses to register with the subsystem (so
we can address multiple CODECs).

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [uclinux-dist-devel] [PATCH] ASoC: Blackfin: allow SPI for SSM2602 parts
  2011-06-17  9:41 ` Mark Brown
@ 2011-06-17 15:21   ` Mike Frysinger
  0 siblings, 0 replies; 4+ messages in thread
From: Mike Frysinger @ 2011-06-17 15:21 UTC (permalink / raw)
  To: Mark Brown; +Cc: uclinux-dist-devel, alsa-devel, Liam Girdwood

On Fri, Jun 17, 2011 at 05:41, Mark Brown wrote:
> On Thu, Jun 16, 2011 at 10:24:15PM -0400, Mike Frysinger wrote:
>> This board has hardware switches for selecting SPI or I2C, so don't
>> require I2C for this driver.
>
> Applied, though I suspect this won't actually load as the different bus
> will change the name the CODEC uses to register with the subsystem (so
> we can address multiple CODECs).

yes, i vaguely recall having to tweak the string name to something
like "spi0.4".  i think this gets back to our discussion about pushing
things into the platform resources.
-mike

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-06-17 15:21 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-17  2:24 [PATCH] ASoC: Blackfin: allow SPI for SSM2602 parts Mike Frysinger
2011-06-17  8:04 ` Liam Girdwood
2011-06-17  9:41 ` Mark Brown
2011-06-17 15:21   ` [uclinux-dist-devel] " Mike Frysinger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox