From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Daniel Mack <zonque@gmail.com>
Cc: alsa-devel@alsa-project.org, lrg@slimlogic.co.uk
Subject: Re: [PATCH] ALSA: ASoC: add STA32X codec driver
Date: Fri, 17 Jun 2011 10:45:31 +0100 [thread overview]
Message-ID: <20110617094531.GC7851@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1308226043-18584-1-git-send-email-zonque@gmail.com>
On Thu, Jun 16, 2011 at 02:07:23PM +0200, Daniel Mack wrote:
Looks very good, a few small nits, if Liam's OK I guess we could fix
these incrementally:
> +#define DEBUG
This shouldn't be in the submission.
> +SOC_SINGLE_TLV("Master Volume", STA32X_MVOL, 0, 0xff, 1, mvol_tlv),
> +SOC_SINGLE("Master Playback Switch", STA32X_MMUTE, 0, 1, 1),
> +SOC_SINGLE("Ch1 Playback Switch", STA32X_MMUTE, 1, 1, 1),
> +SOC_SINGLE("Ch2 Playback Switch", STA32X_MMUTE, 2, 1, 1),
> +SOC_SINGLE("Ch3 Playback Switch", STA32X_MMUTE, 3, 1, 1),
> +SOC_SINGLE_TLV("Ch1 Volume", STA32X_C1VOL, 0, 0xff, 1, chvol_tlv),
> +SOC_SINGLE_TLV("Ch2 Volume", STA32X_C2VOL, 0, 0xff, 1, chvol_tlv),
> +SOC_SINGLE_TLV("Ch3 Volume", STA32X_C3VOL, 0, 0xff, 1, chvol_tlv),
The "Playback" should be consistently either present or not present in
both volume and mute controls so UIs can match them up easily.
next prev parent reply other threads:[~2011-06-17 9:45 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 19:27 ASoC: Patches for an STA32X and WM8782 Daniel Mack
2011-06-14 19:27 ` [PATCH 1/2] ALSA: ASoC: add STA32X codec driver Daniel Mack
2011-06-15 15:05 ` Mark Brown
2011-06-15 20:53 ` Johannes Stezenbach
2011-06-16 8:39 ` Lars-Peter Clausen
2011-06-16 9:12 ` Johannes Stezenbach
2011-06-16 9:51 ` Daniel Mack
2011-06-16 10:13 ` Mark Brown
2011-06-16 11:03 ` Daniel Mack
2011-06-16 11:11 ` Lars-Peter Clausen
2011-06-16 11:26 ` Daniel Mack
2011-06-16 11:38 ` Lars-Peter Clausen
2011-06-16 11:47 ` Daniel Mack
2011-06-16 11:51 ` Lars-Peter Clausen
2011-06-16 11:54 ` Daniel Mack
2011-06-16 8:19 ` Daniel Mack
2011-06-16 8:49 ` Liam Girdwood
2011-06-16 8:53 ` Daniel Mack
2011-06-16 12:07 ` [PATCH] " Daniel Mack
2011-06-17 8:30 ` Daniel Mack
2011-06-17 9:45 ` Mark Brown [this message]
2011-06-17 9:54 ` Daniel Mack
2011-06-22 12:54 ` Mark Brown
2011-06-22 12:59 ` [PATCH 1/2] " Daniel Mack
2011-06-22 12:59 ` [PATCH 2/2] ALSA: ASoC: add WM8782 ADC Codec Driver Daniel Mack
2011-06-22 13:26 ` [PATCH 1/2] ALSA: ASoC: add STA32X codec driver Mark Brown
2011-06-22 13:34 ` Daniel Mack
2011-06-22 13:59 ` Mark Brown
2011-06-22 14:09 ` Paul Menzel
2011-06-20 6:07 ` [PATCH] " Daniel Mack
2011-06-22 11:06 ` Daniel Mack
2011-06-22 11:12 ` Mark Brown
2011-06-22 12:10 ` Liam Girdwood
2011-06-14 19:27 ` [PATCH 2/2] ALSA: ASoC: add WM8782 ADC Codec Driver Daniel Mack
2011-06-15 15:17 ` Mark Brown
2011-06-16 8:20 ` Daniel Mack
2011-06-22 12:12 ` Liam Girdwood
2011-06-15 10:00 ` ASoC: Patches for an STA32X and WM8782 Johannes Stezenbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110617094531.GC7851@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox