From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Dan Carpenter <error27@gmail.com>
Cc: "open list:SOUND - SOC LAYER..." <alsa-devel@alsa-project.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Takashi Iwai <tiwai@suse.de>,
kernel-janitors@vger.kernel.org, Liam Girdwood <lrg@ti.com>
Subject: Re: [patch] ASoC: adau1701: signedness bug in adau1701_write()
Date: Mon, 20 Jun 2011 18:49:16 +0100 [thread overview]
Message-ID: <20110620174916.GA32291@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20110620071125.GG14591@shale.localdomain>
On Mon, Jun 20, 2011 at 10:11:25AM +0300, Dan Carpenter wrote:
> "ret" is supposed to be signed here. The current code will only
> return -EIO on error, instead of a more appropriate error code such
> as -EAGAIN etc.
That changelog is not accurate, if nothing else the code will return
-EINVAL if it can't figure out a length for a register. However, the
change itself is good so applied, thanks.
prev parent reply other threads:[~2011-06-20 17:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 7:11 [patch] ASoC: adau1701: signedness bug in adau1701_write() Dan Carpenter
2011-06-20 10:03 ` Lars-Peter Clausen
2011-06-20 14:03 ` Liam Girdwood
2011-06-20 17:49 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110620174916.GA32291@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=lrg@ti.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox