From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] ASoC: codecs: Max98095: Fix logging of hardware revision. Date: Tue, 21 Jun 2011 12:55:47 +0100 Message-ID: <20110621115547.GD25032@sirena.org.uk> References: <1308596072-17158-1-git-send-email-thutt@chromium.org> <20110621002322.GE1905@opensource.wolfsonmicro.com> <20110621011038.GA4322@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cassiel.sirena.org.uk (cassiel.sirena.org.uk [80.68.93.111]) by alsa0.perex.cz (Postfix) with ESMTP id C8EEE10392A for ; Tue, 21 Jun 2011 13:55:52 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20110621011038.GA4322@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Peter Hsiang Cc: "alsa-devel@alsa-project.org" , Takashi Iwai , "linux-kernel@vger.kernel.org" , Taylor Hutt , Olof Johansson , Liam Girdwood List-Id: alsa-devel@alsa-project.org On Tue, Jun 21, 2011 at 02:10:39AM +0100, Mark Brown wrote: > On Mon, Jun 20, 2011 at 05:43:58PM -0700, Peter Hsiang wrote: > > I checked with hardware engineering and was told 0x40=RevA, 0x41=RevB.. > > Would a raw value or the use of a 0x3F bit mask be more acceptable? > I don't mind (though it does seem like the high bit isn't part of the > actual data), it was just that it's a common error to assume that die > revisions and package revisions correspond directly. This means if you're OK with it I can apply the patch as-is, BTW.