Re: [RFC] ASoC: Add machine driver for i.MX SGTL500 based boards

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

On Mon, Jul 04, 2011 at 03:41:55PM -0300, Fabio Estevam wrote:

> sgtl5000 1-000a: sgtl5000 revision 17                                           
> sgtl5000 1-000a: asoc: failed to probe CODEC sgtl5000.1-000a: -22               
> asoc: failed to instantiate card sgtl5000: -22                                  

Have you looked to see where the error is coming from?

> +	ret = snd_soc_dai_set_sysclk(codec_dai, SGTL5000_LRCLK,
> +						params_rate(params), 0);
> +
> +	if (ret) {
> +		pr_err("%s: failed setting codec sysclk\n", __func__);
> +		return ret;
> +	}

Fix this in the CODEC driver, copying this code into the machine drivers
is clearly not useful.

> +static int __init imx_sgtl5000_init(void)
> +{
> +	int ret;
> +
> +	imx_sgtl5000_snd_device = platform_device_alloc("soc-audio", -1);
> +	if (!imx_sgtl5000_snd_device)
> +		return -ENOMEM;

We're not accepting new drivers using soc-audio, you should use a
regular platform device and register the card with snd_soc_register_card().