From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Scott Jiang <scott.jiang.linux@gmail.com>
Cc: uclinux-dist-devel@blackfin.uclinux.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH v2 3/5] ASoC: ad193x: fix system clock
Date: Mon, 15 Aug 2011 22:35:50 +0900 [thread overview]
Message-ID: <20110815133547.GJ3927@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1313186654-22520-3-git-send-email-scott.jiang.linux@gmail.com>
On Fri, Aug 12, 2011 at 06:04:12PM -0400, Scott Jiang wrote:
> system clock is 24.576MHz instead of 12.288MHz
> sound/soc/blackfin/bf5xx-ad193x.c | 2 +-
This is not a patch for the ad193x driver at all, this is a patch to
one of the Blackfin machine drivers. Please make more effort with your
changelogs all round, I've applied this time but it took a bit of time
to work out what you're trying to do here.
Looking at the code I suspect you want a default case in this switch
statement which returns an error as nothing else really makes sense -
the current code just looks broken.
next prev parent reply other threads:[~2011-08-15 13:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-12 22:04 [PATCH v2 1/5] ASoC: ad193x: fix registers definition Scott Jiang
2011-08-12 21:05 ` Paul Menzel
2011-08-12 22:04 ` [PATCH v2 2/5] ASoC: ad193x: fix dac word len setting Scott Jiang
2011-08-15 2:42 ` Barry Song
2011-08-15 13:29 ` Mark Brown
2011-08-12 22:04 ` [PATCH v2 3/5] ASoC: ad193x: fix system clock Scott Jiang
2011-08-15 13:35 ` Mark Brown [this message]
2011-08-12 22:04 ` [PATCH v2 4/5] ASoC: add spi hw read function for 16 addr 8 data mode Scott Jiang
2011-08-15 2:46 ` Barry Song
2011-08-15 7:03 ` Scott Jiang
2011-08-15 13:37 ` Mark Brown
2011-08-12 22:04 ` [PATCH v2 5/5] ASoC: ad193x: remove cache support Scott Jiang
2011-08-15 13:43 ` Mark Brown
2011-08-15 13:29 ` [PATCH v2 1/5] ASoC: ad193x: fix registers definition Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110815133547.GJ3927@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=scott.jiang.linux@gmail.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox