From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: alsa-devel@alsa-project.org, "Liam Girdwood" <lrg@ti.com>,
"Lambrecht Jürgen" <J.Lambrecht@TELEVIC.com>
Subject: Re: [PATCH] ASoC: Fix check for symmetric rate enforcement
Date: Wed, 17 Aug 2011 15:50:16 +0900 [thread overview]
Message-ID: <20110817065014.GB12344@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20110817062753.GB31404@pengutronix.de>
On Wed, Aug 17, 2011 at 08:27:53AM +0200, Sascha Hauer wrote:
> The ASoC core tries to not enforce symmetric rates when
> two streams open simultaneously. It does so by checking
> rtd->rate being zero. This works exactly once after booting
> because it is not set to zero again when the streams close.
> Fix this by clearing rtd->rate when no active stream is left.
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Applied, thanks. Though I suspect that in practice this may actually be
less robust due to the general raciness of the way we configure and
start the streams - I seem to recall the code works this way semi
deliberately so that we always have a rate selected; most systems only
ever use one rate on symmetric audio interfaces.
next prev parent reply other threads:[~2011-08-17 6:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-17 6:27 [PATCH] ASoC: Fix check for symmetric rate enforcement Sascha Hauer
2011-08-17 6:50 ` Mark Brown [this message]
2011-08-17 6:56 ` Mark Brown
2011-08-17 7:20 ` Sascha Hauer
2011-08-17 7:23 ` Mark Brown
2011-08-17 7:11 ` Sascha Hauer
2011-08-17 7:21 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110817065014.GB12344@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=J.Lambrecht@TELEVIC.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@ti.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox