Re: snd soc spi read/write

Mark Brown
2011-08-10T15:35:02Z

On Wed, Aug 10, 2011 at 05:15:21PM +0200, Takashi Iwai wrote:
> Mark Brown wrote:

> > The idea is that the CODEC drivers will end up using regmap directly
> > once it gets cache support migrated over to it. There's nothing ALSA
> > specific about the cache support. Though right just not bothering to
> > cache this device (it has readback support after all) is probably good
> > enough.

> OK, I like the idea, but it sounds a bit like a long way to go.
> I guess the cache-in-regmap won't be merged in 3.1 cycle?

Well, regmap is only in 3.2.

> Basically I don't care too much about this, but the fact we leave this
> being broken over two release cycles doesn't appear nice, especially
> when there is a quick-n-easy fix...

I don't see a problem with the idea of just making the registers
volatile. There's no real need to cache the registers on a small SPI
device with readback support, the caches mainly benefit I2C (which is
much slower) and devices with no readback support with some other
benefits for larger devices.

That ought to work for all versions of the framework and keeps the
driver looking like a standard driver. There's existing stuff with the
driver doing non-standard things like the fixed default setup which have
been around for quite some time and I'd rather reduce that sort of
stuff.