From: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
To: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
Cc: Jassi Brar
<jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Jassi Brar
<jaswinder.singh-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
gregkh-l3A5Bk7waGM@public.gmane.org,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
zonque-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
yadi.brar01-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH 2/2] USB: Gadget: Add Audio Class 2.0 Driver
Date: Mon, 22 Aug 2011 17:29:18 +0300 [thread overview]
Message-ID: <20110822142917.GU30398@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <20110822142805.GT30398-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 691 bytes --]
Hi,
On Mon, Aug 22, 2011 at 05:28:05PM +0300, Felipe Balbi wrote:
> > >> Otherwise, please have a look at audio.c and audio2.c and suggest what
> > >> exactly you mean.
> > >
> > > audio.c doesn't do anything audio related. It's just adding the
> > > configuration to composite layer. The real specification is implemented
> > > in f_audio.c (should probably be called f_uac1.c, though).
> > Agreed. Reusing audio.c is quite reasonable.
> > So, I'll :-
> > * Merge audio2.c into audio.c
> > * Rename f_audio.c -> f_uac1.c
just another tip/request:
when generating your patches add -M -C switches to git format-patch.
This will let git detect the renaming.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2011-08-22 14:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-19 11:22 [PATCH 2/2] USB: Gadget: Add Audio Class 2.0 Driver Jassi Brar
[not found] ` <1313752934-20081-1-git-send-email-jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-08-22 11:30 ` Felipe Balbi
[not found] ` <20110822113002.GD30398-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2011-08-22 12:37 ` Jassi Brar
[not found] ` <CAJe_Zhdb7d23_x=1GWV2EnEjdn69XBKEz+hCeCuBx4v9XAmykg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-08-22 12:44 ` Felipe Balbi
2011-08-22 13:00 ` Jassi Brar
[not found] ` <CABb+yY3QxvHf38-qfD5ig77nJK=0eVLiSPVpbTh_DCfHNGRyGQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-08-22 13:46 ` Felipe Balbi
[not found] ` <20110822134627.GP30398-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2011-08-22 14:00 ` Jassi Brar
[not found] ` <CABb+yY2m2MfkFwf+XTdKzsCCeSFz_J2LoGxJricamhNtTcSAcg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-08-22 14:28 ` Felipe Balbi
[not found] ` <20110822142805.GT30398-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2011-08-22 14:29 ` Felipe Balbi [this message]
2012-02-02 16:19 ` Jassi Brar
[not found] ` <CABb+yY3X0XDk0zByZZcJOO0h2Kxu14UD4w-GS7p1HPAAWU3SVA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-02-02 16:29 ` [PATCH 1/4] USB: Gadget: Rename audio function to uac1 Jassi Brar
2012-02-15 8:12 ` Felipe Balbi
2012-02-02 16:30 ` [PATCH 2/4] USB: UAC2: Add ACHeader and FormatType descriptor Jassi Brar
2012-02-02 16:31 ` [PATCH 3/4] USB: Gadget: Audio: Move string IDs to audio.c Jassi Brar
2012-02-02 16:31 ` [PATCH 4/4] USB: Gadget: Add Audio Class 2.0 Driver Jassi Brar
2011-08-24 2:00 ` [PATCH 2/2] " Chen Peter-B29397
[not found] ` <35AB98346D25394A9354ED89C4D7658717FD0C-TcFNo7jSaXOLgTCmFNXF2K4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2011-08-24 4:22 ` Jassi Brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110822142917.GU30398@legolas.emea.dhcp.ti.com \
--to=balbi-l0cymroini0@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=gregkh-l3A5Bk7waGM@public.gmane.org \
--cc=jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jaswinder.singh-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=yadi.brar01-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=zonque-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).