From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ben Gardiner <bengardiner@nanometrics.ca>
Cc: davinci-linux-open-source@linux.davincidsp.com,
alsa-devel@alsa-project.org, Sekhar Nori <nsekhar@ti.com>,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] ASoC: davinci-mcasp: add support for unsigned PCM formats
Date: Mon, 29 Aug 2011 10:12:01 +0100 [thread overview]
Message-ID: <20110829091201.GA10838@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1314374564-10291-1-git-send-email-bengardiner@nanometrics.ca>
On Fri, Aug 26, 2011 at 12:02:44PM -0400, Ben Gardiner wrote:
> Although the McASP supports sign-extending samples in RX or TX [1]; the
> davinci-mcasp driver does not touch the {R,X}PBIT or {R,X}PAD field of the
> {R,X}FMT registers meaning that the McASP will serialize the bytes it is given
> regardless of their signedness. So supporting unsigned formats is as simple
> as adding them to the metadata of the davinci-mcasp driver.
Applied, thanks.
prev parent reply other threads:[~2011-08-29 9:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-26 16:02 [PATCH] ASoC: davinci-mcasp: add support for unsigned PCM formats Ben Gardiner
2011-08-28 17:39 ` Liam Girdwood
2011-08-29 9:12 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110829091201.GA10838@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=bengardiner@nanometrics.ca \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=lrg@ti.com \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).