From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Timur Tabi <timur@freescale.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH 1/3] ASoC: support sample sizes properly in the WM8776 codec driver
Date: Thu, 15 Sep 2011 11:26:43 +0100 [thread overview]
Message-ID: <20110915102643.GE7988@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4E7121DC.908@freescale.com>
On Wed, Sep 14, 2011 at 04:51:24PM -0500, Timur Tabi wrote:
> >> + i = snd_pcm_format_width(params_format(params));
> >> + switch (i) {
> > Just a minor nitpick. I would not have used the intermediate 'i' here
> > and would have just embedded the snd_pcm call within the switch(). I
> > guess it may not fit the line width though.
> 'i' is used twice:
> switch (i) {
> and
> dev_err(codec->dev, "Unsupported sample size: %i\n", i);
There's no meaningful cost in calling the function twice and it'd be
much more legible to do so.
next prev parent reply other threads:[~2011-09-15 10:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-13 17:59 [PATCH 1/3] ASoC: support sample sizes properly in the WM8776 codec driver Timur Tabi
2011-09-13 17:59 ` [PATCH 2/3] ASoC: support all possible sample rates in the WM8776 driver Timur Tabi
2011-09-14 12:36 ` Liam Girdwood
2011-09-15 10:24 ` Mark Brown
2011-09-15 15:08 ` Timur Tabi
2011-09-15 22:38 ` Mark Brown
2011-09-15 23:06 ` Tabi Timur-B04825
2011-09-15 23:49 ` Mark Brown
2011-09-16 13:48 ` Timur Tabi
2011-09-17 13:04 ` Mark Brown
2011-09-13 17:59 ` [PATCH 3/3] ASoC: improve asynchronous mode support in the fsl_ssi driver Timur Tabi
2011-09-14 12:37 ` Liam Girdwood
2011-09-15 23:06 ` Mark Brown
2011-09-15 23:49 ` Mark Brown
2011-09-14 12:35 ` [PATCH 1/3] ASoC: support sample sizes properly in the WM8776 codec driver Liam Girdwood
2011-09-14 21:51 ` Timur Tabi
2011-09-15 10:26 ` Mark Brown [this message]
2011-09-15 11:28 ` Tabi Timur-B04825
2011-09-15 13:21 ` Mark Brown
2011-09-15 15:16 ` Timur Tabi
2011-09-15 23:38 ` Mark Brown
2011-09-16 9:07 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110915102643.GE7988@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@ti.com \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).