* [RFC][PATCH] ASoC: Make wm1250-ev1 depends on GPIOLIB
@ 2011-09-27 2:49 Axel Lin
2011-09-27 9:48 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2011-09-27 2:49 UTC (permalink / raw)
To: linux-kernel; +Cc: Liam Girdwood, Mark Brown, alsa-devel
I got below build error if GPIO support is disabled.
Make wm1250-ev1 depends on GPIOLIB to fix below build error.
CC sound/soc/codecs/wm1250-ev1.o
sound/soc/codecs/wm1250-ev1.c:32:14: error: array type has incomplete element type
sound/soc/codecs/wm1250-ev1.c: In function ‘wm1250_ev1_pdata’:
sound/soc/codecs/wm1250-ev1.c:126:18: warning: type defaults to ‘int’ in type name
sound/soc/codecs/wm1250-ev1.c:126:18: warning: type defaults to ‘int’ in type name
sound/soc/codecs/wm1250-ev1.c:126:18: error: negative width in bit-field ‘<anonymous>’
sound/soc/codecs/wm1250-ev1.c:134:42: warning: type defaults to ‘int’ in type name
sound/soc/codecs/wm1250-ev1.c:134:42: warning: type defaults to ‘int’ in type name
sound/soc/codecs/wm1250-ev1.c:134:42: error: negative width in bit-field ‘<anonymous>’
sound/soc/codecs/wm1250-ev1.c: In function ‘wm1250_ev1_free’:
sound/soc/codecs/wm1250-ev1.c:155:34: warning: type defaults to ‘int’ in type name
sound/soc/codecs/wm1250-ev1.c:155:34: warning: type defaults to ‘int’ in type name
sound/soc/codecs/wm1250-ev1.c:155:34: error: negative width in bit-field ‘<anonymous>’
make[3]: *** [sound/soc/codecs/wm1250-ev1.o] Error 1
make[2]: *** [sound/soc/codecs] Error 2
make[1]: *** [sound/soc] Error 2
make: *** [sound] Error 2
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
I got the build error while trying to build for SND_MFLD_MACHINE and SND_SST_PLATFORM.
( "Enable ALSA for SoC audio support" and "Build all ASoC CODEC drivers" on X86 )
Axel
sound/soc/codecs/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index 3449431..0ad80fe 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -58,7 +58,7 @@ config SND_SOC_ALL_CODECS
select SND_SOC_UDA134X
select SND_SOC_UDA1380 if I2C
select SND_SOC_WL1273 if MFD_WL1273_CORE
- select SND_SOC_WM1250_EV1 if I2C
+ select SND_SOC_WM1250_EV1 if I2C && GPIOLIB
select SND_SOC_WM2000 if I2C
select SND_SOC_WM5100 if I2C
select SND_SOC_WM8350 if MFD_WM8350
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RFC][PATCH] ASoC: Make wm1250-ev1 depends on GPIOLIB
2011-09-27 2:49 [RFC][PATCH] ASoC: Make wm1250-ev1 depends on GPIOLIB Axel Lin
@ 2011-09-27 9:48 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2011-09-27 9:48 UTC (permalink / raw)
To: Axel Lin; +Cc: alsa-devel, linux-kernel, Liam Girdwood
On Tue, Sep 27, 2011 at 10:49:59AM +0800, Axel Lin wrote:
> I got below build error if GPIO support is disabled.
> Make wm1250-ev1 depends on GPIOLIB to fix below build error.
If platforms aren't using the standard gpiolib infrastructure they
should keep their GPIO API implementation up to date with the current
state of the art.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-09-27 9:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-27 2:49 [RFC][PATCH] ASoC: Make wm1250-ev1 depends on GPIOLIB Axel Lin
2011-09-27 9:48 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).