From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 06/10] ASoC: twl6040: correct loop counters for HS/HF ramp code Date: Tue, 27 Sep 2011 12:12:34 +0100 Message-ID: <20110927111234.GG2910@opensource.wolfsonmicro.com> References: <1317043593-27202-1-git-send-email-peter.ujfalusi@ti.com> <1317043593-27202-7-git-send-email-peter.ujfalusi@ti.com> <20110926213259.GF2872@opensource.wolfsonmicro.com> <1946709.L1hqkRcruS@barack> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from opensource.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id 0ED2610394A for ; Tue, 27 Sep 2011 13:12:37 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1946709.L1hqkRcruS@barack> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: =?iso-8859-1?Q?P=E9ter?= Ujfalusi Cc: alsa-devel@alsa-project.org, Liam Girdwood , Misael Lopez Cruz List-Id: alsa-devel@alsa-project.org On Tue, Sep 27, 2011 at 09:21:14AM +0300, P=E9ter Ujfalusi wrote: > On Monday 26 September 2011 22:33:01 Mark Brown wrote: > > On Mon, Sep 26, 2011 at 04:26:29PM +0300, Peter Ujfalusi wrote: > > > - for (i =3D 0; i <=3D 16; i++) { > > > + for (i =3D 0; i <=3D 15; i++) { > > It'd seem more natural to change these to being simple < comparisons - > > they're far more common. Any great reason for going tis way (perhaps > > context?). > No particular reason IMHO, just a copy from the wm8350 driver. > I'll check how they look like in assembly, it could be that <=3D is bette= r in = > ARM? It's not like it's getting used throughout the rest of the code and that's a trivial optimization for a compiler...