From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Jassi Brar <jassisinghbrar@gmail.com>,
Sangbeom Kim <sbkim73@samsung.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Liam Girdwood <lrg@ti.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: samsung: s3c-i2s-v2.c needs module.h
Date: Sun, 2 Oct 2011 19:26:06 +0100 [thread overview]
Message-ID: <20111002182605.GC2857@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1317562466.4996.2.camel@phoenix>
On Sun, Oct 02, 2011 at 09:34:26PM +0800, Axel Lin wrote:
> Include <linux/module.h> to fix below build error:
>
> CC sound/soc/samsung/s3c-i2s-v2.o
> sound/soc/samsung/s3c-i2s-v2.c:573: warning: data definition has no type or storage class
What tree is this for? My primary development platform is based on this
driver, I'd expect to have noticed any build issues and I rather suspect
this isn't what you're supposed to do after all the module.h stuff has
settled down.
next prev parent reply other threads:[~2011-10-02 18:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-02 13:34 [PATCH] ASoC: samsung: s3c-i2s-v2.c needs module.h Axel Lin
2011-10-02 18:26 ` Mark Brown [this message]
2011-10-03 0:17 ` Axel Lin
2011-10-03 10:30 ` Mark Brown
2011-10-03 16:03 ` Paul Gortmaker
2011-10-03 17:01 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111002182605.GC2857@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=paul.gortmaker@windriver.com \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).