From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ben Gardiner <bengardiner@nanometrics.ca>
Cc: davinci-linux-open-source@linux.davincidsp.com,
alsa-devel@alsa-project.org, Sekhar Nori <nsekhar@ti.com>,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH 1/3] ASoC: davinci-pcm: latch EDMA errors
Date: Sun, 2 Oct 2011 19:48:42 +0100 [thread overview]
Message-ID: <20111002184842.GF2857@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <647c53d57c6dc6b9780f7f1ad21f39106e702566.1317417232.git.bengardiner@nanometrics.ca>
On Fri, Sep 30, 2011 at 05:23:01PM -0400, Ben Gardiner wrote:
> The davinci-pcm driver currently ignores all EDMA completion callbacks that
> could be indicating an error.
> Latch any edma error-status callbacks and report them as SNDDRV_PCM_POS_XRUN
> like is done in fsl_dma.c.
Nothing in this patch ever seems to clear the flag which seems rather
extreme. I'd expect that if you're going to do this then the flag would
be cleared after one error has been reported.
> In testing when an error occured early-on in playback the stream did not halt,
> but several underruns were reported until eventually the stream halted.
> Is there a better way to report HW errors up the stack?
Not really, and it's not clear that it's constructive to try - if
there's a problem that doesn't otherwise cause a failure then generally
the user will intervene.
next prev parent reply other threads:[~2011-10-02 18:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 21:23 [RFC 0/3] ASoC: davinci- pcm and McASP error detection Ben Gardiner
2011-09-30 21:23 ` [PATCH 1/3] ASoC: davinci-pcm: latch EDMA errors Ben Gardiner
2011-10-02 18:48 ` Mark Brown [this message]
2011-10-04 2:04 ` Ben Gardiner
2011-09-30 21:23 ` [RFC 2/3] ASoC: davinci-pcm: add cpu-dai health callbacks Ben Gardiner
2011-10-02 18:54 ` Mark Brown
2011-10-04 2:05 ` Ben Gardiner
2011-10-04 11:06 ` Mark Brown
2011-09-30 21:23 ` [RFC 3/3] ASoC: davinci-mcasp: add cpu dai health callback Ben Gardiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111002184842.GF2857@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=bengardiner@nanometrics.ca \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=lrg@ti.com \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).