From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ben Gardiner <bengardiner@nanometrics.ca>
Cc: davinci-linux-open-source@linux.davincidsp.com,
alsa-devel@alsa-project.org, Sekhar Nori <nsekhar@ti.com>,
Liam Girdwood <lrg@ti.com>
Subject: Re: [RFC 2/3] ASoC: davinci-pcm: add cpu-dai health callbacks
Date: Sun, 2 Oct 2011 19:54:35 +0100 [thread overview]
Message-ID: <20111002185434.GH2857@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <beb331a90431ab4dfefedc45f53e686df3bc3f61.1317417232.git.bengardiner@nanometrics.ca>
On Fri, Sep 30, 2011 at 05:23:02PM -0400, Ben Gardiner wrote:
> The CPU DAIs available to the davinci-pcm driver have the capability of
> detecting and reporting errors.
> Add callbacks to the struct davinci_pcm_dma_params passed to davinci-pcm
> from the CPU DAI.
This looks like something we should be doing at the subsystem level, the
DaVinci is far from unique in having the ability to detect errors at the
DAI level.
> This has several shortcomings:
> 1) It bubbles up to the user as underruns, not a fatal error -- some may prefer
> the former, I realize but the latter is more attractive to me. Same problem
> as with the previous patch in this series.
Why do you prefer a fatal error, and how do you distinguish a fatal
error from a glitch?
next prev parent reply other threads:[~2011-10-02 18:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 21:23 [RFC 0/3] ASoC: davinci- pcm and McASP error detection Ben Gardiner
2011-09-30 21:23 ` [PATCH 1/3] ASoC: davinci-pcm: latch EDMA errors Ben Gardiner
2011-10-02 18:48 ` Mark Brown
2011-10-04 2:04 ` Ben Gardiner
2011-09-30 21:23 ` [RFC 2/3] ASoC: davinci-pcm: add cpu-dai health callbacks Ben Gardiner
2011-10-02 18:54 ` Mark Brown [this message]
2011-10-04 2:05 ` Ben Gardiner
2011-10-04 11:06 ` Mark Brown
2011-09-30 21:23 ` [RFC 3/3] ASoC: davinci-mcasp: add cpu dai health callback Ben Gardiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111002185434.GH2857@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=bengardiner@nanometrics.ca \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=lrg@ti.com \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).