* [PATCH] ASoC: Fix setting update bits for WM8753_LADC and WM8753_RADC
@ 2011-10-02 12:41 Axel Lin
2011-10-02 18:56 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2011-10-02 12:41 UTC (permalink / raw)
To: linux-kernel; +Cc: alsa-devel, Lars-Peter Clausen, Liam Girdwood, Mark Brown
Current code set update bits for WM8753_LDAC and WM8753_RDAC twice,
but missed setting update bits for WM8753_LADC and WM8753_RADC.
I think it is a copy-paste bug in commit 776065
"ASoC: codecs: wm8753: Fix register cache incoherency".
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
sound/soc/codecs/wm8753.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/wm8753.c b/sound/soc/codecs/wm8753.c
index fe04a10..a950471 100644
--- a/sound/soc/codecs/wm8753.c
+++ b/sound/soc/codecs/wm8753.c
@@ -1455,8 +1455,8 @@ static int wm8753_probe(struct snd_soc_codec *codec)
/* set the update bits */
snd_soc_update_bits(codec, WM8753_LDAC, 0x0100, 0x0100);
snd_soc_update_bits(codec, WM8753_RDAC, 0x0100, 0x0100);
- snd_soc_update_bits(codec, WM8753_LDAC, 0x0100, 0x0100);
- snd_soc_update_bits(codec, WM8753_RDAC, 0x0100, 0x0100);
+ snd_soc_update_bits(codec, WM8753_LADC, 0x0100, 0x0100);
+ snd_soc_update_bits(codec, WM8753_RADC, 0x0100, 0x0100);
snd_soc_update_bits(codec, WM8753_LOUT1V, 0x0100, 0x0100);
snd_soc_update_bits(codec, WM8753_ROUT1V, 0x0100, 0x0100);
snd_soc_update_bits(codec, WM8753_LOUT2V, 0x0100, 0x0100);
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: Fix setting update bits for WM8753_LADC and WM8753_RADC
2011-10-02 12:41 [PATCH] ASoC: Fix setting update bits for WM8753_LADC and WM8753_RADC Axel Lin
@ 2011-10-02 18:56 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2011-10-02 18:56 UTC (permalink / raw)
To: Axel Lin; +Cc: alsa-devel, Lars-Peter Clausen, linux-kernel, Liam Girdwood
On Sun, Oct 02, 2011 at 08:41:04PM +0800, Axel Lin wrote:
> Current code set update bits for WM8753_LDAC and WM8753_RDAC twice,
> but missed setting update bits for WM8753_LADC and WM8753_RADC.
>
> I think it is a copy-paste bug in commit 776065
> "ASoC: codecs: wm8753: Fix register cache incoherency".
Looks like it, yes. Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-02 18:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-02 12:41 [PATCH] ASoC: Fix setting update bits for WM8753_LADC and WM8753_RADC Axel Lin
2011-10-02 18:56 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).