* [PATCH] ASoC: Remove needless codec->dapm.bias_level assignment to SND_SOC_BIAS_OFF
@ 2011-10-03 12:17 Axel Lin
2011-10-03 13:16 ` Mark Brown
2011-10-03 13:18 ` Mark Brown
0 siblings, 2 replies; 4+ messages in thread
From: Axel Lin @ 2011-10-03 12:17 UTC (permalink / raw)
To: linux-kernel
Cc: Harsha Priya, Vinod Koul, Mark Brown, Liam Girdwood, alsa-devel
This assignment is done by the snd_soc_register_codec so there is no need
to redo it in probe function of a codec driver.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
sound/soc/codecs/sn95031.c | 1 -
sound/soc/codecs/wm5100.c | 2 --
sound/soc/codecs/wm8996.c | 1 -
3 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs/sn95031.c b/sound/soc/codecs/sn95031.c
index adb85bf..09c4593 100644
--- a/sound/soc/codecs/sn95031.c
+++ b/sound/soc/codecs/sn95031.c
@@ -827,7 +827,6 @@ static int sn95031_codec_probe(struct snd_soc_codec *codec)
{
pr_debug("codec_probe called\n");
- codec->dapm.bias_level = SND_SOC_BIAS_OFF;
codec->dapm.idle_bias_off = 1;
/* PCM interface config
diff --git a/sound/soc/codecs/wm5100.c b/sound/soc/codecs/wm5100.c
index f603989..46afdf86 100644
--- a/sound/soc/codecs/wm5100.c
+++ b/sound/soc/codecs/wm5100.c
@@ -2285,8 +2285,6 @@ static int wm5100_probe(struct snd_soc_codec *codec)
wm5100->codec = codec;
- codec->dapm.bias_level = SND_SOC_BIAS_OFF;
-
ret = snd_soc_codec_set_cache_io(codec, 16, 16, SND_SOC_I2C);
if (ret != 0) {
dev_err(codec->dev, "Failed to set cache I/O: %d\n", ret);
diff --git a/sound/soc/codecs/wm8996.c b/sound/soc/codecs/wm8996.c
index b98a8f8..43e46c7 100644
--- a/sound/soc/codecs/wm8996.c
+++ b/sound/soc/codecs/wm8996.c
@@ -2706,7 +2706,6 @@ static int wm8996_probe(struct snd_soc_codec *codec)
init_completion(&wm8996->fll_lock);
dapm->idle_bias_off = true;
- dapm->bias_level = SND_SOC_BIAS_OFF;
ret = snd_soc_codec_set_cache_io(codec, 16, 16, SND_SOC_I2C);
if (ret != 0) {
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ASoC: Remove needless codec->dapm.bias_level assignment to SND_SOC_BIAS_OFF
2011-10-03 12:17 [PATCH] ASoC: Remove needless codec->dapm.bias_level assignment to SND_SOC_BIAS_OFF Axel Lin
@ 2011-10-03 13:16 ` Mark Brown
2011-10-03 13:18 ` Mark Brown
1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2011-10-03 13:16 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel, Liam Girdwood, Vinod Koul, Harsha Priya, alsa-devel
On Mon, Oct 03, 2011 at 08:17:16PM +0800, Axel Lin wrote:
> This assignment is done by the snd_soc_register_codec so there is no need
> to redo it in probe function of a codec driver.
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: Remove needless codec->dapm.bias_level assignment to SND_SOC_BIAS_OFF
2011-10-03 12:17 [PATCH] ASoC: Remove needless codec->dapm.bias_level assignment to SND_SOC_BIAS_OFF Axel Lin
2011-10-03 13:16 ` Mark Brown
@ 2011-10-03 13:18 ` Mark Brown
2011-10-04 4:57 ` Vinod Koul
1 sibling, 1 reply; 4+ messages in thread
From: Mark Brown @ 2011-10-03 13:18 UTC (permalink / raw)
To: Axel Lin; +Cc: Vinod Koul, linux-kernel, alsa-devel, Liam Girdwood
On Mon, Oct 03, 2011 at 08:17:16PM +0800, Axel Lin wrote:
> This assignment is done by the snd_soc_register_codec so there is no need
> to redo it in probe function of a codec driver.
Axel, please stop CCing Harsha Priya on patches - you should've
noticed that his address bounces by now.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: Remove needless codec->dapm.bias_level assignment to SND_SOC_BIAS_OFF
2011-10-03 13:18 ` Mark Brown
@ 2011-10-04 4:57 ` Vinod Koul
0 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2011-10-04 4:57 UTC (permalink / raw)
To: Mark Brown; +Cc: Axel Lin, linux-kernel, alsa-devel, Liam Girdwood
On Mon, 2011-10-03 at 14:18 +0100, Mark Brown wrote:
> On Mon, Oct 03, 2011 at 08:17:16PM +0800, Axel Lin wrote:
> > This assignment is done by the snd_soc_register_codec so there is no need
> > to redo it in probe function of a codec driver.
>
> Axel, please stop CCing Harsha Priya on patches - you should've
> noticed that his address bounces by now.
Hmmm, i can send a patch to update her email id. But for now i dont
think she will work on kernel
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-10-04 5:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-03 12:17 [PATCH] ASoC: Remove needless codec->dapm.bias_level assignment to SND_SOC_BIAS_OFF Axel Lin
2011-10-03 13:16 ` Mark Brown
2011-10-03 13:18 ` Mark Brown
2011-10-04 4:57 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).