From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: alsa-devel@alsa-project.org, Sangbeom Kim <sbkim73@samsung.com>,
Jassi Brar <jassisinghbrar@gmail.com>,
linux-kernel@vger.kernel.org, Axel Lin <axel.lin@gmail.com>,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] ASoC: samsung: s3c-i2s-v2.c needs module.h
Date: Mon, 3 Oct 2011 18:01:22 +0100 [thread overview]
Message-ID: <20111003170121.GR3731@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4E89DCC7.4010703@windriver.com>
On Mon, Oct 03, 2011 at 12:03:19PM -0400, Paul Gortmaker wrote:
> On 11-10-03 06:30 AM, Mark Brown wrote:
> > That's exactly what I'm running at the minute with no problem...
> Then I'm guessing you don't have the option for it enabled (as
I'm pretty sure I'd have noticed if I wasn't building the driver, my
systems would be a lot less noisy than it currently is.
> Thanks Axel, I'll squish this into the commit that adds module.h
> to all the other sound drivers that have it missing.
Now that we've worked out what it's for I don't see any reason not to
apply Axel's patch right now so I've done that.
It would be useful if you could send your patches for module.h
upstream, there's no reason to avoid sending them now and it'd be useful
to cut down on the noise from small merge issues.
prev parent reply other threads:[~2011-10-03 17:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-02 13:34 [PATCH] ASoC: samsung: s3c-i2s-v2.c needs module.h Axel Lin
2011-10-02 18:26 ` Mark Brown
2011-10-03 0:17 ` Axel Lin
2011-10-03 10:30 ` Mark Brown
2011-10-03 16:03 ` Paul Gortmaker
2011-10-03 17:01 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111003170121.GR3731@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=paul.gortmaker@windriver.com \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).