* [PATCH] ASoC: samsung: s3c-i2s-v2.c needs module.h
@ 2011-10-02 13:34 Axel Lin
2011-10-02 18:26 ` Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: Axel Lin @ 2011-10-02 13:34 UTC (permalink / raw)
To: linux-kernel
Cc: alsa-devel, Mark Brown, Sangbeom Kim, Jassi Brar, Paul Gortmaker,
Liam, Girdwood
Include <linux/module.h> to fix below build error:
CC sound/soc/samsung/s3c-i2s-v2.o
sound/soc/samsung/s3c-i2s-v2.c:573: warning: data definition has no type or storage class
sound/soc/samsung/s3c-i2s-v2.c:573: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
sound/soc/samsung/s3c-i2s-v2.c:573: warning: parameter names (without types) in function declaration
sound/soc/samsung/s3c-i2s-v2.c:638: warning: data definition has no type or storage class
sound/soc/samsung/s3c-i2s-v2.c:638: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
sound/soc/samsung/s3c-i2s-v2.c:638: warning: parameter names (without types) in function declaration
sound/soc/samsung/s3c-i2s-v2.c:677: warning: data definition has no type or storage class
sound/soc/samsung/s3c-i2s-v2.c:677: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
sound/soc/samsung/s3c-i2s-v2.c:677: warning: parameter names (without types) in function declaration
sound/soc/samsung/s3c-i2s-v2.c: In function 's3c_i2sv2_register_dai':
sound/soc/samsung/s3c-i2s-v2.c:736: warning: initialization discards qualifiers from pointer target type
sound/soc/samsung/s3c-i2s-v2.c: At top level:
sound/soc/samsung/s3c-i2s-v2.c:754: warning: data definition has no type or storage class
sound/soc/samsung/s3c-i2s-v2.c:754: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
sound/soc/samsung/s3c-i2s-v2.c:754: warning: parameter names (without types) in function declaration
sound/soc/samsung/s3c-i2s-v2.c:756: error: expected declaration specifiers or '...' before string constant
sound/soc/samsung/s3c-i2s-v2.c:756: warning: data definition has no type or storage class
sound/soc/samsung/s3c-i2s-v2.c:756: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
sound/soc/samsung/s3c-i2s-v2.c:756: warning: function declaration isn't a prototype
make[3]: *** [sound/soc/samsung/s3c-i2s-v2.o] Error 1
make[2]: *** [sound/soc/samsung] Error 2
make[1]: *** [sound/soc] Error 2
make: *** [sound] Error 2
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
This patch is against linux-next (20110930).
sound/soc/samsung/s3c-i2s-v2.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/sound/soc/samsung/s3c-i2s-v2.c b/sound/soc/samsung/s3c-i2s-v2.c
index 52074a2b..7a73380 100644
--- a/sound/soc/samsung/s3c-i2s-v2.c
+++ b/sound/soc/samsung/s3c-i2s-v2.c
@@ -16,6 +16,7 @@
* option) any later version.
*/
+#include <linux/module.h>
#include <linux/delay.h>
#include <linux/clk.h>
#include <linux/io.h>
--
1.7.4.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: samsung: s3c-i2s-v2.c needs module.h
2011-10-02 13:34 [PATCH] ASoC: samsung: s3c-i2s-v2.c needs module.h Axel Lin
@ 2011-10-02 18:26 ` Mark Brown
2011-10-03 0:17 ` Axel Lin
0 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2011-10-02 18:26 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel, Jassi Brar, Sangbeom Kim, Paul Gortmaker,
Liam Girdwood, alsa-devel
On Sun, Oct 02, 2011 at 09:34:26PM +0800, Axel Lin wrote:
> Include <linux/module.h> to fix below build error:
>
> CC sound/soc/samsung/s3c-i2s-v2.o
> sound/soc/samsung/s3c-i2s-v2.c:573: warning: data definition has no type or storage class
What tree is this for? My primary development platform is based on this
driver, I'd expect to have noticed any build issues and I rather suspect
this isn't what you're supposed to do after all the module.h stuff has
settled down.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: samsung: s3c-i2s-v2.c needs module.h
2011-10-02 18:26 ` Mark Brown
@ 2011-10-03 0:17 ` Axel Lin
2011-10-03 10:30 ` Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: Axel Lin @ 2011-10-03 0:17 UTC (permalink / raw)
To: Mark Brown
Cc: alsa-devel, Sangbeom Kim, Jassi Brar, linux-kernel,
Paul Gortmaker, Liam Girdwood
2011/10/3 Mark Brown <broonie@opensource.wolfsonmicro.com>:
> On Sun, Oct 02, 2011 at 09:34:26PM +0800, Axel Lin wrote:
>> Include <linux/module.h> to fix below build error:
>>
>> CC sound/soc/samsung/s3c-i2s-v2.o
>> sound/soc/samsung/s3c-i2s-v2.c:573: warning: data definition has no type or storage class
>
> What tree is this for? My primary development platform is based on this
> driver, I'd expect to have noticed any build issues and I rather suspect
> this isn't what you're supposed to do after all the module.h stuff has
> settled down.
>
I got the build error on linux-next (20110930).
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: samsung: s3c-i2s-v2.c needs module.h
2011-10-03 0:17 ` Axel Lin
@ 2011-10-03 10:30 ` Mark Brown
2011-10-03 16:03 ` Paul Gortmaker
0 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2011-10-03 10:30 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel, Jassi Brar, Sangbeom Kim, Paul Gortmaker,
Liam Girdwood, alsa-devel
On Mon, Oct 03, 2011 at 08:17:21AM +0800, Axel Lin wrote:
> 2011/10/3 Mark Brown <broonie@opensource.wolfsonmicro.com>:
> > What tree is this for? ?My primary development platform is based on this
> > driver, I'd expect to have noticed any build issues and I rather suspect
> > this isn't what you're supposed to do after all the module.h stuff has
> > settled down.
> I got the build error on linux-next (20110930).
That's exactly what I'm running at the minute with no problem...
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: samsung: s3c-i2s-v2.c needs module.h
2011-10-03 10:30 ` Mark Brown
@ 2011-10-03 16:03 ` Paul Gortmaker
2011-10-03 17:01 ` Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: Paul Gortmaker @ 2011-10-03 16:03 UTC (permalink / raw)
To: Mark Brown
Cc: Axel Lin, linux-kernel, Jassi Brar, Sangbeom Kim, Liam Girdwood,
alsa-devel
On 11-10-03 06:30 AM, Mark Brown wrote:
> On Mon, Oct 03, 2011 at 08:17:21AM +0800, Axel Lin wrote:
>> 2011/10/3 Mark Brown <broonie@opensource.wolfsonmicro.com>:
>
>>> What tree is this for? ?My primary development platform is based on this
>>> driver, I'd expect to have noticed any build issues and I rather suspect
>>> this isn't what you're supposed to do after all the module.h stuff has
>>> settled down.
>
>> I got the build error on linux-next (20110930).
>
> That's exactly what I'm running at the minute with no problem...
Then I'm guessing you don't have the option for it enabled (as
the s3c2410_defconfig doesn't enable it, it seems).
I reproduced it with the following commands:
28 git checkout next-20110930
29 mkdir ../arm-sam
30 make O=../arm-sam s3c2410_defconfig
31 nice make O=../arm-foo/ sound/soc/samsung/s3c-i2s-v2.o
Thanks Axel, I'll squish this into the commit that adds module.h
to all the other sound drivers that have it missing.
Paul.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: samsung: s3c-i2s-v2.c needs module.h
2011-10-03 16:03 ` Paul Gortmaker
@ 2011-10-03 17:01 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2011-10-03 17:01 UTC (permalink / raw)
To: Paul Gortmaker
Cc: alsa-devel, Sangbeom Kim, Jassi Brar, linux-kernel, Axel Lin,
Liam Girdwood
On Mon, Oct 03, 2011 at 12:03:19PM -0400, Paul Gortmaker wrote:
> On 11-10-03 06:30 AM, Mark Brown wrote:
> > That's exactly what I'm running at the minute with no problem...
> Then I'm guessing you don't have the option for it enabled (as
I'm pretty sure I'd have noticed if I wasn't building the driver, my
systems would be a lot less noisy than it currently is.
> Thanks Axel, I'll squish this into the commit that adds module.h
> to all the other sound drivers that have it missing.
Now that we've worked out what it's for I don't see any reason not to
apply Axel's patch right now so I've done that.
It would be useful if you could send your patches for module.h
upstream, there's no reason to avoid sending them now and it'd be useful
to cut down on the noise from small merge issues.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-10-03 17:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-02 13:34 [PATCH] ASoC: samsung: s3c-i2s-v2.c needs module.h Axel Lin
2011-10-02 18:26 ` Mark Brown
2011-10-03 0:17 ` Axel Lin
2011-10-03 10:30 ` Mark Brown
2011-10-03 16:03 ` Paul Gortmaker
2011-10-03 17:01 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).