From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Austin, Brian" <Brian.Austin@cirrus.com>
Cc: "<alsa-devel@alsa-project.org>" <alsa-devel@alsa-project.org>,
"<vinod.koul@linux.intel.com>" <vinod.koul@linux.intel.com>,
"<lrg@ti.com>" <lrg@ti.com>,
"<ramesh.babu@intel.com>" <ramesh.babu@intel.com>,
"<joe@nucleusys.com>" <joe@nucleusys.com>
Subject: Re: [PATCH v2] ASoC: Add support for cs42l73 codec
Date: Tue, 4 Oct 2011 22:38:39 +0100 [thread overview]
Message-ID: <20111004213839.GA7328@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <B2795634-3EDA-4EEC-9107-ED8B1D3AD374@cirrus.com>
On Tue, Oct 04, 2011 at 05:53:10PM +0000, Austin, Brian wrote:
> On Oct 2, 2011, at 1:40 PM, Mark Brown wrote:
> > On Fri, Sep 30, 2011 at 11:41:52AM -0500, Brian Austin wrote:
> >> + SOC_DOUBLE("ADC Boost Switch", CS42L73_ADCIPC, 2, 6, 1, 0),
> > This should be a Volume control with TLV information assuming it does
> > what it sounds like and makes the signal louder.
> This is just 0dB or 25dB so now it's just an enum if that's OK.
No, you can still show the gain with TLV information so it renders
nicely in UIs.
> >> + SOC_SINGLE("HL Limiter Release Rate Volume", CS42L73_LIMRRATEHL, 0,
> >> + 0x3F, 0),
> > Similarly here, you probably want an enumaration showing the rates.
> This is a range of values that are used to set the rate by setting the step period size.
> It's values are 0 - 3F. I'm hoping to leave it as an SOC_SINGLE control if possible
Well, you should certainly drop the "Volume" from the name.
prev parent reply other threads:[~2011-10-04 21:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 16:41 [PATCH v2] ASoC: Add support for cs42l73 codec Brian Austin
2011-09-30 17:34 ` Vinod Koul
2011-09-30 18:32 ` Austin, Brian
2011-10-01 17:22 ` Vinod Koul
2011-09-30 18:50 ` Lars-Peter Clausen
2011-09-30 19:19 ` Austin, Brian
2011-10-01 5:04 ` Babu, Ramesh
2011-10-05 21:55 ` Austin, Brian
2011-10-02 18:40 ` Mark Brown
2011-10-04 17:53 ` Austin, Brian
2011-10-04 19:17 ` Austin, Brian
2011-10-05 10:40 ` Mark Brown
2011-10-04 21:38 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111004213839.GA7328@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=Brian.Austin@cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=joe@nucleusys.com \
--cc=lrg@ti.com \
--cc=ramesh.babu@intel.com \
--cc=vinod.koul@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).