From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Brian Austin <brian.austin@cirrus.com>
Cc: alsa-devel@alsa-project.org, vinod.koul@linux.intel.com,
joe@nucleusys.com, ramesh.babu@intel.com, lrg@ti.com
Subject: Re: [PATCH v3] ASoC: Add support for cs42l73 codec
Date: Thu, 6 Oct 2011 19:57:47 +0100 [thread overview]
Message-ID: <20111006185746.GA17685@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1317917945-32580-1-git-send-email-brian.austin@cirrus.com>
On Thu, Oct 06, 2011 at 11:19:05AM -0500, Brian Austin wrote:
> + {"DAC1 Mixer", "Headphone Switch", "XSPIN"},
> + {"DAC1 Mixer", "LineOut Switch", "XSPIN"},
> + {"DAC2 Mixer", "Speakerphone Switch", "XSPIN"},
> + {"DAC2 Mixer", "Speakerphone LineOut Switch", "XSPIN"},
> + {"DAC2 Mixer", "EarSpeaker Switch", "XSPIN"},
> + {"DAC1 Mixer", "Headphone Switch", "ASPIN"},
> + {"DAC1 Mixer", "LineOut Switch", "ASPIN"},
> + {"DAC2 Mixer", "Speakerphone Switch", "ASPIN"},
> + {"DAC2 Mixer", "Speakerphone LineOut Switch", "ASPIN"},
> + {"DAC2 Mixer", "EarSpeaker Switch", "ASPIN"},
> + {"DAC1 Mixer", "Headphone Switch", "VSPIN"},
> + {"DAC1 Mixer", "LineOut Switch", "VSPIN"},
> + {"DAC2 Mixer", "Speakerphone Switch", "VSPIN"},
> + {"DAC2 Mixer", "Speakerphone LineOut Switch", "VSPIN"},
> + {"DAC2 Mixer", "EarSpeaker Switch", "VSPIN"},
This all looks totally wrong and I'm surprised the driver loads without
errors. There's two issues:
- All the controls here are for the input to the DAC mixers but their
names are for physical outputs. I'd expect the switches to name
inputs (for example, "DAC1 Mixer VSPIN Switch"). What's actually
going on here?
- You've got three copies of each of the controls for each mixer - I'm
surprsied this loads without the core complaining that it can't
create controls with duplicate names.
next prev parent reply other threads:[~2011-10-06 19:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-06 16:19 [PATCH v3] ASoC: Add support for cs42l73 codec Brian Austin
2011-10-06 18:57 ` Mark Brown [this message]
2011-10-06 19:15 ` Austin, Brian
2011-10-07 10:34 ` Mark Brown
2011-10-07 11:07 ` Vinod Koul
2011-10-07 11:42 ` Mark Brown
2011-10-07 14:05 ` Austin, Brian
2011-10-07 14:27 ` Mark Brown
2011-10-07 14:29 ` Vinod Koul
2011-10-12 15:58 ` Austin, Brian
2011-10-12 21:37 ` Austin, Brian
2011-10-12 21:50 ` Austin, Brian
2011-10-12 21:55 ` Austin, Brian
2011-10-17 19:11 ` Austin, Brian
2011-10-17 20:15 ` Mark Brown
2011-10-07 3:59 ` Vinod Koul
2011-10-07 2:13 ` Tabi Timur-B04825
2011-10-07 10:27 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111006185746.GA17685@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=brian.austin@cirrus.com \
--cc=joe@nucleusys.com \
--cc=lrg@ti.com \
--cc=ramesh.babu@intel.com \
--cc=vinod.koul@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).