* [PATCH] ASoC: Tegra: sparse cleanup
@ 2011-10-14 22:54 Olof Johansson
[not found] ` <1318632859-14796-1-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
2011-10-17 21:43 ` Mark Brown
0 siblings, 2 replies; 4+ messages in thread
From: Olof Johansson @ 2011-10-14 22:54 UTC (permalink / raw)
To: Mark Brown
Cc: Liam Girdwood, swarren-DDmLM1+adcrQT0dZR+AlfA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw, Olof Johansson
Fixes the following sparse warnings:
sound/soc/tegra/tegra_das.c:215:8: warning: Using plain integer as NULL pointer
sound/soc/tegra/tegra_das.c:237:8: warning: Using plain integer as NULL pointer
sound/soc/tegra/tegra_pcm.c:370:32: warning: symbol 'tegra_pcm_platform' was not declared. Should it be static?
Signed-off-by: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
---
sound/soc/tegra/tegra_das.c | 4 ++--
sound/soc/tegra/tegra_pcm.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/tegra/tegra_das.c b/sound/soc/tegra/tegra_das.c
index 9f24ef7..3b55a44 100644
--- a/sound/soc/tegra/tegra_das.c
+++ b/sound/soc/tegra/tegra_das.c
@@ -212,7 +212,7 @@ err_release:
release_mem_region(res->start, resource_size(res));
err_free:
kfree(das);
- das = 0;
+ das = NULL;
exit:
return ret;
}
@@ -234,7 +234,7 @@ static int __devexit tegra_das_remove(struct platform_device *pdev)
release_mem_region(res->start, resource_size(res));
kfree(das);
- das = 0;
+ das = NULL;
return 0;
}
diff --git a/sound/soc/tegra/tegra_pcm.c b/sound/soc/tegra/tegra_pcm.c
index c7cfd96..436def1 100644
--- a/sound/soc/tegra/tegra_pcm.c
+++ b/sound/soc/tegra/tegra_pcm.c
@@ -367,7 +367,7 @@ static void tegra_pcm_free(struct snd_pcm *pcm)
tegra_pcm_deallocate_dma_buffer(pcm, SNDRV_PCM_STREAM_PLAYBACK);
}
-struct snd_soc_platform_driver tegra_pcm_platform = {
+static struct snd_soc_platform_driver tegra_pcm_platform = {
.ops = &tegra_pcm_ops,
.pcm_new = tegra_pcm_new,
.pcm_free = tegra_pcm_free,
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] ASoC: Tegra: sparse cleanup
[not found] ` <1318632859-14796-1-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
@ 2011-10-14 22:59 ` Stephen Warren
[not found] ` <74CDBE0F657A3D45AFBB94109FB122FF173BE1A3ED-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Warren @ 2011-10-14 22:59 UTC (permalink / raw)
To: Olof Johansson, Mark Brown
Cc: Liam Girdwood,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org
Olof Johansson wrote at Friday, October 14, 2011 4:54 PM:
> Fixes the following sparse warnings:
>
> sound/soc/tegra/tegra_das.c:215:8: warning: Using plain integer as NULL pointer
> sound/soc/tegra/tegra_das.c:237:8: warning: Using plain integer as NULL pointer
> sound/soc/tegra/tegra_pcm.c:370:32: warning: symbol 'tegra_pcm_platform' was not declared. Should it
> be static?
>
> Signed-off-by: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
Acked-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Grumble, in C++ 0==NULL... :-)
--
nvpublic
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: Tegra: sparse cleanup
[not found] ` <74CDBE0F657A3D45AFBB94109FB122FF173BE1A3ED-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
@ 2011-10-14 23:01 ` Olof Johansson
0 siblings, 0 replies; 4+ messages in thread
From: Olof Johansson @ 2011-10-14 23:01 UTC (permalink / raw)
To: Stephen Warren
Cc: Mark Brown, Liam Girdwood,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org
On Fri, Oct 14, 2011 at 3:59 PM, Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> wrote:
> Olof Johansson wrote at Friday, October 14, 2011 4:54 PM:
>> Fixes the following sparse warnings:
>>
>> sound/soc/tegra/tegra_das.c:215:8: warning: Using plain integer as NULL pointer
>> sound/soc/tegra/tegra_das.c:237:8: warning: Using plain integer as NULL pointer
>> sound/soc/tegra/tegra_pcm.c:370:32: warning: symbol 'tegra_pcm_platform' was not declared. Should it
>> be static?
>>
>> Signed-off-by: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
>
> Acked-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
> Grumble, in C++ 0==NULL... :-)
In C too, it's just sparse that is extra picky.
-Olof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: Tegra: sparse cleanup
2011-10-14 22:54 [PATCH] ASoC: Tegra: sparse cleanup Olof Johansson
[not found] ` <1318632859-14796-1-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
@ 2011-10-17 21:43 ` Mark Brown
1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2011-10-17 21:43 UTC (permalink / raw)
To: Olof Johansson; +Cc: linux-tegra, alsa-devel, swarren, Liam Girdwood
On Fri, Oct 14, 2011 at 03:54:19PM -0700, Olof Johansson wrote:
> Fixes the following sparse warnings:
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-10-17 21:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-14 22:54 [PATCH] ASoC: Tegra: sparse cleanup Olof Johansson
[not found] ` <1318632859-14796-1-git-send-email-olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
2011-10-14 22:59 ` Stephen Warren
[not found] ` <74CDBE0F657A3D45AFBB94109FB122FF173BE1A3ED-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2011-10-14 23:01 ` Olof Johansson
2011-10-17 21:43 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).