From: Wolfram Sang <w.sang@pengutronix.de>
To: "Girdwood, Liam" <lrg@ti.com>
Cc: Axel Lin <axel.lin@gmail.com>,
linux-kernel@vger.kernel.org,
Zeng Zhaoming <zhaoming.zeng@freescale.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/2] ASoC: sgtl5000: Fix define for SGTL5000_BIAS_R_MASK
Date: Wed, 19 Oct 2011 12:05:59 +0200 [thread overview]
Message-ID: <20111019100559.GC3217@pengutronix.de> (raw)
In-Reply-To: <CABS+qY2n2xXVvK=CqOPXfH2YOYijPwSAc7tH=CYL1AJXGPxBNQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1448 bytes --]
On Wed, Oct 19, 2011 at 09:06:57AM +0100, Girdwood, Liam wrote:
> On 19 October 2011 03:54, Axel Lin <axel.lin@gmail.com> wrote:
> > According to the datasheet:
> > CHIP_MIC_CTRL 0x002A
> >
> > BITS[9:8] BIAS_RESISTOR
> > 0x0 = Powerd off
> > 0x1 = 2.0 kohm
> > 0x2 = 4.0 kohm
> > 0x3 = 8.0 kohm
> >
> > Thus SGTL5000_BIAS_R_MASK should be defined as 0x0300 instead of 0x0200.
> >
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
> > ---
> > sound/soc/codecs/sgtl5000.h | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/sound/soc/codecs/sgtl5000.h b/sound/soc/codecs/sgtl5000.h
> > index eec3ab3..8a9f435 100644
> > --- a/sound/soc/codecs/sgtl5000.h
> > +++ b/sound/soc/codecs/sgtl5000.h
> > @@ -280,7 +280,7 @@
> > /*
> > * SGTL5000_CHIP_MIC_CTRL
> > */
> > -#define SGTL5000_BIAS_R_MASK 0x0200
> > +#define SGTL5000_BIAS_R_MASK 0x0300
> > #define SGTL5000_BIAS_R_SHIFT 8
> > #define SGTL5000_BIAS_R_WIDTH 2
> > #define SGTL5000_BIAS_R_off 0x0
> > --
> > 1.7.5.4
> >
> >
> >
> >
>
> Both
>
> Acked-by: Liam Girdwood <lrg@ti.com>
And
Acked-by: Wolfram Sang <w.sang@pengutronix.de>
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2011-10-19 10:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-19 2:54 [PATCH 1/2] ASoC: sgtl5000: Fix define for SGTL5000_BIAS_R_MASK Axel Lin
2011-10-19 3:00 ` [PATCH 2/2] ASoC: sgtl5000: Fix setting mic bias resistor Axel Lin
2011-10-19 8:06 ` [PATCH 1/2] ASoC: sgtl5000: Fix define for SGTL5000_BIAS_R_MASK Girdwood, Liam
2011-10-19 10:05 ` Wolfram Sang [this message]
2011-10-19 12:09 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111019100559.GC3217@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=zhaoming.zeng@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).