alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <w.sang@pengutronix.de>
To: David Jander <david.jander@protonic.nl>
Cc: alsa-devel@alsa-project.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Liam Girdwood <lrg@ti.com>
Subject: Re: ASoC driver parts probing order (MPC5200/MPC5121)
Date: Thu, 20 Oct 2011 12:59:40 +0200	[thread overview]
Message-ID: <20111020105940.GB2379@pengutronix.de> (raw)
In-Reply-To: <20111020122317.6c705289@archvile>


[-- Attachment #1.1: Type: text/plain, Size: 1340 bytes --]

Hi David,

> I am writing a AC97 ASoC driver for the MPC5121e SoC from Freescale. This SoC
> has almost the same PSC (Programmable Serial Controllers) as the MPC5200B, for
> which there already is an AC97 driver: sound/soc/fsl/mpc5200-ac97.c, so I'd
> like to extend that one to also support the MPC5121e.

Yes, this seems feasible. It has been done like this for the uart-driver, sadly
not for the spi-driver :(

> So obviously, it is supposed that the DMA driver
> somehow gets probed before the PSC driver, but I can't see where this is
> enforced. AFAIK, the order is fairly random, so it could be the other way

Check arch/powerpc/sysdev/bestcomm/bestcomm.c at the end:

/* If we're not a module, we must make sure everything is setup before  */
/* anyone tries to use us ... that's why we use subsys_initcall instead */
/* of module_init. */
subsys_initcall(mpc52xx_bcom_init);

while the mpc5121-driver has simply module_init() here. subsys_initcall() is
also often used for I2C host drivers to ensure client drivers can access them
early.

> 1.- I can't test it on a MPC5200B, so therefor I need help.

I can do tests.

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2011-10-20 10:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-20 10:23 ASoC driver parts probing order (MPC5200/MPC5121) David Jander
2011-10-20 10:59 ` Wolfram Sang [this message]
2011-10-20 11:37   ` David Jander
2011-10-20 12:13     ` Wolfram Sang
2011-10-20 12:27       ` David Jander
2011-10-20 12:35 ` Mark Brown
2011-10-20 13:26   ` David Jander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111020105940.GB2379@pengutronix.de \
    --to=w.sang@pengutronix.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=david.jander@protonic.nl \
    --cc=lrg@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).