alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: David Jander <david.jander@protonic.nl>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>
Subject: Re: ASoC driver parts probing order (MPC5200/MPC5121)
Date: Thu, 20 Oct 2011 13:35:13 +0100	[thread overview]
Message-ID: <20111020123513.GA3484@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20111020122317.6c705289@archvile>

On Thu, Oct 20, 2011 at 12:23:17PM +0200, David Jander wrote:

> of the probe function. So obviously, it is supposed that the DMA driver
> somehow gets probed before the PSC driver, but I can't see where this is
> enforced. AFAIK, the order is fairly random, so it could be the other way
> around.... and indeed, in my case it is.

The order the device model devices get probed in is entirely random and
any driver which is relying on this is buggy.

> 2.- Simply turning the dev_get/set_drvdata and chip initialization order
> around does work in my case, but doesn't seem a robust solution to me. Any
> idea how this should be handled?

I'd expect that delaying whatever relies on both devices being there
until the ASoC level probes happen is the way forward - you're
guaranteed that both deivces will be present there and the probe
ordering is guaranteed stable.

  parent reply	other threads:[~2011-10-20 12:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-20 10:23 ASoC driver parts probing order (MPC5200/MPC5121) David Jander
2011-10-20 10:59 ` Wolfram Sang
2011-10-20 11:37   ` David Jander
2011-10-20 12:13     ` Wolfram Sang
2011-10-20 12:27       ` David Jander
2011-10-20 12:35 ` Mark Brown [this message]
2011-10-20 13:26   ` David Jander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111020123513.GA3484@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=david.jander@protonic.nl \
    --cc=lrg@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).