Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Tull Alan-R80115 <R80115@freescale.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"lrg@slimlogic.co.uk" <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC don't clobber platform DMA driver ops
Date: Tue, 1 Nov 2011 19:11:06 +0000	[thread overview]
Message-ID: <20111101191106.GM10029@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <9E5C29D1DC97674D8FB0F7D26508F7861F0620@039-SN1MPN1-005.039d.mgd.msft.net>

On Tue, Nov 01, 2011 at 06:57:47PM +0000, Tull Alan-R80115 wrote:

On public Linux lists you should never top post (so people have context
and know what you're talking about) and you should fix your mail client
to word wrap within paragraphs.

> I originally started down the path you are describing, but quickly ran
> into problems.  I started by adding a soc_pcm_copy and soc_pcm_mmap
> and found that I needed to pull code from ALSA core in to handle the
> case where copy or mmap was NULL for a given platform driver.  

In that case your changelog needs to explain this and I'd still use a
function for those ops that don't have stubs in the core.  Things like
ioctl() could usefully be routed to all the drivers, for example.

  parent reply	other threads:[~2011-11-01 19:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-01 18:45 [PATCH] ASoC don't clobber platform DMA driver ops Alan Tull
     [not found] ` <9E5C29D1DC97674D8FB0F7D26508F7861F05DB@039-SN1MPN1-005.039d.mgd.msft.net>
2011-11-01 18:49   ` Mark Brown
     [not found]     ` <9E5C29D1DC97674D8FB0F7D26508F7861F0620@039-SN1MPN1-005.039d.mgd.msft.net>
2011-11-01 19:11       ` Mark Brown [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-11-01 21:05 Alan Tull
2011-11-02  3:40 ` Tabi Timur-B04825
2011-11-02 10:24   ` Mark Brown
2011-11-10 11:43 ` Mark Brown
2011-11-10 15:14   ` r80115
2011-11-10 15:16     ` Mark Brown
2011-11-10 15:20       ` r80115
2011-11-10 15:25         ` Mark Brown
2011-11-15 15:59 Alan Tull
2011-11-15 16:56 ` Tabi Timur-B04825
2011-11-15 17:22   ` r80115

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111101191106.GM10029@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=R80115@freescale.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=lrg@slimlogic.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox