From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Péter Ujfalusi" <peter.ujfalusi@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
Liam Girdwood <lrg@ti.com>, Benoit Cousson <b-cousson@ti.com>
Subject: Re: [PATCH v3 2/5] ASoC: OMAP4: omap-dmic: Initial support for OMAP DMIC
Date: Mon, 28 Nov 2011 11:44:05 +0000 [thread overview]
Message-ID: <20111128114404.GE2934@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <2729071.3pgFW4tmaY@barack>
On Mon, Nov 28, 2011 at 09:49:19AM +0200, Péter Ujfalusi wrote:
> On Sunday 27 November 2011 19:50:41 Mark Brown wrote:
> > So what happens if the user starts recording at 192kHz then goes back to
> > 96kHz? This all feels a bit clunky and fragile.
> I expect another HW param calls. The stream is stopped, and I reconfigure the
> divider for 96KHz (I will not change the divider here, since the stream is
> 96KHz). I don't see any issue here.
Only if the user is using the same machine driver as you. If the user
wants a fixed clock rate for the DMIC and sets it on init rather than
resetting it every time hw_params() is called then this will break.
next prev parent reply other threads:[~2011-11-28 11:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-25 12:20 [PATCH v3 0/5] Support for OMAP4 Digital Microphone interface Peter Ujfalusi
2011-11-25 12:20 ` [PATCH v3 1/5] OMAP4: hwmod: Add names for DMIC memory address space Peter Ujfalusi
2011-11-25 12:20 ` [PATCH v3 2/5] ASoC: OMAP4: omap-dmic: Initial support for OMAP DMIC Peter Ujfalusi
2011-11-27 19:50 ` Mark Brown
2011-11-28 7:49 ` Péter Ujfalusi
2011-11-28 11:44 ` Mark Brown [this message]
2011-11-28 13:39 ` Péter Ujfalusi
2011-11-25 12:20 ` [PATCH v3 3/5] OMAP4: devices: Register OMAP4 DMIC platform device Peter Ujfalusi
2011-11-25 12:20 ` [PATCH v3 4/5] OMAP4: board-4430sdp: Register platform device for digimic codec Peter Ujfalusi
2011-11-25 12:20 ` [PATCH v3 5/5] ASoC: sdp4430: Add support for digital microphones Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111128114404.GE2934@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=b-cousson@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox