From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: alsa-devel@alsa-project.org, Lars-Peter Clausen <lars@metafoo.de>,
Liam Girdwood <lrg@ti.com>,
Philipp Zabel <philipp.zabel@gmail.com>
Subject: Re: [PATCH 1/3] ASoC: uda1380: Return proper error in uda1380_modinit failure path
Date: Sun, 4 Dec 2011 13:00:18 +0000 [thread overview]
Message-ID: <20111204130018.GA8461@sirena.org.uk> (raw)
In-Reply-To: <1322998520.12391.1.camel@phoenix>
On Sun, Dec 04, 2011 at 07:35:20PM +0800, Axel Lin wrote:
> + int ret = 0;
> #if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
> ret = i2c_add_driver(&uda1380_i2c_driver);
> if (ret != 0)
> pr_err("Failed to register UDA1380 I2C driver: %d\n", ret);
> #endif
> - return 0;
> + return ret;
In cases like this where only I2C is supported it's best to just remove
all the ifdefs for I2C completely.
next prev parent reply other threads:[~2011-12-04 13:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-04 11:35 [PATCH 1/3] ASoC: uda1380: Return proper error in uda1380_modinit failure path Axel Lin
2011-12-04 11:37 ` [PATCH 2/3] ASoC: uda1380: Fix missed uda1380_reset call if pdata->gpio_power is a valid gpio Axel Lin
2011-12-04 13:02 ` Mark Brown
2011-12-04 18:55 ` Vasily
2011-12-04 11:38 ` [PATCH 3/3] ASoC: uda1380: Convert to gpio_request_one() Axel Lin
2011-12-04 23:46 ` Mark Brown
2011-12-04 13:00 ` Mark Brown [this message]
2011-12-04 13:44 ` [PATCH 1/3] ASoC: uda1380: Return proper error in uda1380_modinit failure path Axel Lin
2011-12-04 23:39 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111204130018.GA8461@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=lars@metafoo.de \
--cc=lrg@ti.com \
--cc=philipp.zabel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox