From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Cc: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
alsa-devel@alsa-project.org, Lars-Peter Clausen <lars@metafoo.de>,
Mike Frysinger <vapier@gentoo.org>,
qi.wang@intel.com, Takashi Iwai <tiwai@suse.de>,
linux-kernel@vger.kernel.org, yong.y.wang@intel.com,
kok.howg.ewe@intel.com, Daniel Mack <zonque@gmail.com>,
Liam Girdwood <lrg@ti.com>,
joel.clark@intel.com
Subject: Re: [PATCH v3] sound/soc/lapis: add machine driver v3 updated
Date: Fri, 9 Dec 2011 20:24:59 +0800 [thread overview]
Message-ID: <20111209122457.GA29492@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1323428632-29309-1-git-send-email-tomoya.rohm@gmail.com>
On Fri, Dec 09, 2011 at 08:03:52PM +0900, Tomoya MORINAGA wrote:
> + snd_soc_dapm_new_controls(dapm, ml7213_dapm_widgets,
> + ARRAY_SIZE(ml7213_dapm_widgets));
> +
> + snd_soc_dapm_add_routes(dapm, ml7213_routes, ARRAY_SIZE(ml7213_routes));
You should also use table based init for these (see the card struct).
Otherwise this looks good, though obviously there's a dependency on the
CPU drivers.
next prev parent reply other threads:[~2011-12-09 12:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-09 11:03 [PATCH v3] sound/soc/lapis: add machine driver v3 updated Tomoya MORINAGA
2011-12-09 12:24 ` Mark Brown [this message]
2011-12-12 6:56 ` Tomoya MORINAGA
2011-12-12 6:57 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111209122457.GA29492@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=dp@opensource.wolfsonmicro.com \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=qi.wang@intel.com \
--cc=tiwai@suse.de \
--cc=tomoya.rohm@gmail.com \
--cc=vapier@gentoo.org \
--cc=yong.y.wang@intel.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).