From: Wolfram Sang <w.sang@pengutronix.de>
To: "Lothar Waßmann" <LW@KARO-electronics.de>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Dong Aisheng-B29396 <B29396@freescale.com>,
linux-kernel@vger.kernel.org, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH 3/5] ASoC: mxs: Export symbols 'mxs_saif_put_mclk()' and 'mxs_saif_get_mclk()'
Date: Fri, 9 Dec 2011 15:15:30 +0100 [thread overview]
Message-ID: <20111209141530.GI3327@pengutronix.de> (raw)
In-Reply-To: <42d1579aefe3a3025f16fb4e38a4acf6b72756f7.1323436034.git.LW@KARO-electronics.de>
[-- Attachment #1.1: Type: text/plain, Size: 1010 bytes --]
On Fri, Dec 09, 2011 at 02:38:10PM +0100, Lothar Waßmann wrote:
> Fixes the following errors with MXS sound support built as module:
> |ERROR: "mxs_saif_put_mclk" [sound/soc/mxs/snd-soc-mxs-sgtl5000.ko] undefined!
> |ERROR: "mxs_saif_get_mclk" [sound/soc/mxs/snd-soc-mxs-sgtl5000.ko] undefined!
>
> Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
> ---
> sound/soc/mxs/mxs-saif.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/mxs/mxs-saif.c b/sound/soc/mxs/mxs-saif.c
> index 487d2ff..ec66a29 100644
> --- a/sound/soc/mxs/mxs-saif.c
> +++ b/sound/soc/mxs/mxs-saif.c
> @@ -221,6 +221,7 @@ int mxs_saif_put_mclk(unsigned int saif_id)
> saif->mclk_in_use = 0;
> return 0;
> }
> +EXPORT_SYMBOL(mxs_saif_put_mclk);
EXPORT_SYMBOL_GPL. I'd vote this is an implementation issue.
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2011-12-09 14:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-09 13:38 [PATCH 0/5] ASoC: mxs: Several cleanups and bugfixes for the MXS sound driver Lothar Waßmann
2011-12-09 13:38 ` [PATCH 1/5] ASoC: mxs: General cleanups Lothar Waßmann
2011-12-09 13:38 ` [PATCH 2/5] ASoC: mxs: add .owner to struct snd_soc_card Lothar Waßmann
2011-12-09 13:38 ` [PATCH 3/5] ASoC: mxs: Export symbols 'mxs_saif_put_mclk()' and 'mxs_saif_get_mclk()' Lothar Waßmann
2011-12-09 13:38 ` [PATCH 4/5] ASoC: mxs: Add missing MODULE_LICENSE("GPL") Lothar Waßmann
2011-12-09 13:38 ` [PATCH 5/5] ASoC: mxs: Add appropriate MODULE_ALIAS() Lothar Waßmann
2011-12-09 14:17 ` Wolfram Sang
2011-12-11 2:59 ` Mark Brown
2011-12-09 14:17 ` [PATCH 4/5] ASoC: mxs: Add missing MODULE_LICENSE("GPL") Wolfram Sang
2011-12-11 2:59 ` Mark Brown
2011-12-09 14:15 ` Wolfram Sang [this message]
2011-12-11 2:55 ` [PATCH 3/5] ASoC: mxs: Export symbols 'mxs_saif_put_mclk()' and 'mxs_saif_get_mclk()' Mark Brown
2011-12-09 14:12 ` [PATCH 2/5] ASoC: mxs: add .owner to struct snd_soc_card Wolfram Sang
2011-12-09 14:36 ` Lothar Waßmann
2011-12-11 2:53 ` Mark Brown
2011-12-12 9:10 ` [alsa-devel] " Lothar Waßmann
2011-12-12 10:04 ` Mark Brown
2011-12-09 14:07 ` [PATCH 1/5] ASoC: mxs: General cleanups Wolfram Sang
2011-12-11 3:03 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111209141530.GI3327@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=B29396@freescale.com \
--cc=LW@KARO-electronics.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).