* [PATCH] ASoC: WM8958: correctly show firmware magic on mismatch
@ 2011-12-11 18:15 Jonathan Neuschäfer
2011-12-12 4:58 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Jonathan Neuschäfer @ 2011-12-11 18:15 UTC (permalink / raw)
To: alsa-devel, linux-kernel
Cc: Mark Brown, Ian Lartey, Dimitris Papastamos, Liam Girdwood,
Jaroslav Kysela, Takashi Iwai, Jonathan Neuschäfer
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
This patch is untested.
sound/soc/codecs/wm8958-dsp2.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/sound/soc/codecs/wm8958-dsp2.c b/sound/soc/codecs/wm8958-dsp2.c
index 0293763..5a14d5c 100644
--- a/sound/soc/codecs/wm8958-dsp2.c
+++ b/sound/soc/codecs/wm8958-dsp2.c
@@ -60,6 +60,8 @@ static int wm8958_dsp2_fw(struct snd_soc_codec *codec, const char *name,
}
if (memcmp(fw->data, "WMFW", 4) != 0) {
+ memcpy(&data32, fw->data, sizeof(data32));
+ data32 = be32_to_cpu(data32);
dev_err(codec->dev, "%s: firmware has bad file magic %08x\n",
name, data32);
goto err;
--
1.7.7.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: WM8958: correctly show firmware magic on mismatch
2011-12-11 18:15 [PATCH] ASoC: WM8958: correctly show firmware magic on mismatch Jonathan Neuschäfer
@ 2011-12-12 4:58 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2011-12-12 4:58 UTC (permalink / raw)
To: Jonathan Neuschäfer
Cc: alsa-devel, linux-kernel, Ian Lartey, Dimitris Papastamos,
Liam Girdwood, Jaroslav Kysela, Takashi Iwai
On Sun, Dec 11, 2011 at 07:15:49PM +0100, Jonathan Neuschäfer wrote:
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-12-12 4:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-11 18:15 [PATCH] ASoC: WM8958: correctly show firmware magic on mismatch Jonathan Neuschäfer
2011-12-12 4:58 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).