From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Cc: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
alsa-devel@alsa-project.org, Lars-Peter Clausen <lars@metafoo.de>,
Mike Frysinger <vapier@gentoo.org>,
qi.wang@intel.com, Takashi Iwai <tiwai@suse.de>,
linux-kernel@vger.kernel.org, yong.y.wang@intel.com,
kok.howg.ewe@intel.com, Daniel Mack <zonque@gmail.com>,
Liam Girdwood <lrg@ti.com>,
joel.clark@intel.com
Subject: Re: [PATCH 3/3] sound/soc/lapis: add platform driver
Date: Mon, 12 Dec 2011 10:05:14 +0000 [thread overview]
Message-ID: <20111212100513.GA5017@sirena.org.uk> (raw)
In-Reply-To: <CANKRQnivyNXNZPnaUOHwpXpJz+kCz6gOwfqYNwkcOo5EpsSvZQ@mail.gmail.com>
On Mon, Dec 12, 2011 at 05:28:13PM +0900, Tomoya MORINAGA wrote:
> struct snd_soc_ops {
> ...
> };
> On the other hand, tegra_i2s.c describes like below.
> static const struct snd_soc_dai_ops tegra_i2s_dai_ops = {
> ...
> };
> Which is true as modern driver ? or case by case ?
The latter. With things like this it would be *really* helpful if you
could take a step back and think about what the differences mean and why
they are different.
>
> >> +#define I2S_CH0_MCLK (12288000) /* Master Clock Frequency[Hz] */
> > This looks like it should be board specific?
> Should our platform driver use "clk_get()" ?
> If no, how should our driver get the value ?
Again, with things like this it would be really helpful if you could
attempt to answer questions for yourself. Have you looked at how other
platforms configure clock rates from machine drivers?
next prev parent reply other threads:[~2011-12-12 10:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1321848532-8784-1-git-send-email-tomoya.rohm@gmail.com>
2011-11-21 11:26 ` [PATCH 1/3] sound/soc/codecs: add LAPIS Semiconductor ML26124 Mark Brown
2011-11-22 10:47 ` Tomoya MORINAGA
2011-11-22 11:19 ` Mark Brown
2011-11-25 2:03 ` Tomoya MORINAGA
2011-11-25 11:02 ` Mark Brown
[not found] ` <1321848532-8784-2-git-send-email-tomoya.rohm@gmail.com>
2011-11-21 11:34 ` [PATCH 2/3] sound/soc/lapis: add machine driver Mark Brown
2011-12-02 5:33 ` Tomoya MORINAGA
2011-12-02 6:14 ` Takashi Iwai
2011-12-02 6:18 ` Tomoya MORINAGA
2011-12-02 6:39 ` Takashi Iwai
2011-12-02 6:52 ` Tomoya MORINAGA
2011-12-02 7:01 ` Takashi Iwai
2011-12-02 7:13 ` Tomoya MORINAGA
2011-12-02 7:16 ` Takashi Iwai
2011-12-02 11:46 ` Mark Brown
2011-12-02 12:09 ` Tomoya MORINAGA
2011-12-02 12:22 ` Mark Brown
2011-12-02 12:35 ` Tomoya MORINAGA
2011-12-02 12:49 ` Mark Brown
[not found] ` <1321848532-8784-3-git-send-email-tomoya.rohm@gmail.com>
2011-11-21 11:45 ` [PATCH 3/3] sound/soc/lapis: add platform driver Mark Brown
2011-12-12 8:28 ` Tomoya MORINAGA
2011-12-12 10:05 ` Mark Brown [this message]
2011-12-13 4:38 ` Tomoya MORINAGA
2011-12-13 4:59 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111212100513.GA5017@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=dp@opensource.wolfsonmicro.com \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=qi.wang@intel.com \
--cc=tiwai@suse.de \
--cc=tomoya.rohm@gmail.com \
--cc=vapier@gentoo.org \
--cc=yong.y.wang@intel.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).