From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Leon Romanovsky <leon@leon.nu>
Cc: alsa-devel@alsa-project.org, lrg@ti.com
Subject: Re: [PATCH] ASoC: Rename ALC5632 MICBIAS to common name convention.
Date: Tue, 13 Dec 2011 14:28:50 +0800 [thread overview]
Message-ID: <20111213062848.GB7148@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CALq1K=+AjQAUwUn8N6JKY-nRGwC+qre=0_9J-FknRNsx1eJT6w@mail.gmail.com>
On Tue, Dec 13, 2011 at 08:25:29AM +0200, Leon Romanovsky wrote:
> On Tue, Dec 13, 2011 at 03:36, Mark Brown
> > > +SND_SOC_DAPM_SUPPLY("MICBIAS1", ALC5632_PWR_MANAG_ADD1, 3, 0, NULL, 0),
> > > +SND_SOC_DAPM_SUPPLY("MICBIAS2", ALC5632_PWR_MANAG_ADD1, 2, 0, NULL, 0),
> > What does the datasheet say the pins are called?
> MICBIAS
> http://ac100.wikispaces.com/file/view/alc5632_micbiases.PNG/285333934/alc5632_micbiases.PNG
OK - you should've said this in your changelog, that's what the
convention is, to use the pin names.
prev parent reply other threads:[~2011-12-13 6:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 19:43 [PATCH] ASoC: Rename ALC5632 MICBIAS to common name convention Leon Romanovsky
2011-12-13 1:36 ` Mark Brown
2011-12-13 6:25 ` Leon Romanovsky
2011-12-13 6:28 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111213062848.GB7148@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=leon@leon.nu \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).