From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Michael Williamson <michael.williamson@criticallink.com>
Cc: alsa-devel@alsa-project.org, lars@metafoo.de,
Liam Girdwood <lrg@ti.com>,
leon@leon.nu
Subject: Re: [PATCH] ASoC: dsd1791: Introduce driver for TI DSD1791 stereo codec
Date: Tue, 20 Dec 2011 00:40:35 +0000 [thread overview]
Message-ID: <20111220004034.GF2860@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4EEFBA29.4090903@criticallink.com>
On Mon, Dec 19, 2011 at 05:26:49PM -0500, Michael Williamson wrote:
> On 12/19/2011 04:44 PM, Liam Girdwood wrote:
> > Looks mostly fine, just a few comments :-
> Thanks for the review. I will address your comments. One question, below.
Guys, please delete irrelevant context from your mails.
> >> +{
> >> + snd_soc_unregister_codec(&spi->dev);
> > What about your private data ?
> My understanding is devm_kzalloc'd memory would be
> freed up by the device framework. Is this not
> correct?
Your understanding is correct, that's the whole point of devm_kzalloc().
next prev parent reply other threads:[~2011-12-20 0:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-19 18:53 [PATCH] ASoC: dsd1791: Introduce driver for TI DSD1791 stereo codec Michael Williamson
2011-12-19 21:44 ` Liam Girdwood
2011-12-19 22:26 ` Michael Williamson
2011-12-20 0:40 ` Mark Brown [this message]
2011-12-20 0:39 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111220004034.GF2860@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lars@metafoo.de \
--cc=leon@leon.nu \
--cc=lrg@ti.com \
--cc=michael.williamson@criticallink.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox