Re: [PATCH 3/3 v2] sound/soc/lapis: add platform driver for ML7213 IOH I2S

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

On Thu, Dec 22, 2011 at 05:10:24PM +0900, Tomoya MORINAGA wrote:

> I can understand your saying.
> However, in case of Tx interrupt, only ALMOST-EMPTY occurs. in case of
> Rx, only Rx ALMOST-FULL occurs.
> So as long as a user uses ML7213 I2S, your mentioned behavior is never happened.

That's not what your code says...  it may be that the other interrupts
are very rare but that's not the same thing.

> They have the "filter" function immediately next to the code uses
> "dma_request_channel".

That's a rather large function...

> Anyway, if you want me to change the name, I can change the name.
> Please decide it.

Rename.

> > You're implementing some sort of custom buffering in your driver?  That
> > sounds terribly unidiomatic - pretty much all DMA drivers are very thin
> > and manage to work well, I'd expect this is masking some problems in the
> > code rather than anything else.  Can you provide more detail on what
> > this is working around?

> Not sorted but queuing only.
> In sound/voice control system, queuing is not rare, I think.
> If necessary, though this method is very common, I can send the method
> of the queue.

No, please describe the problem you're trying to fix.  If nothing else
think about what you're saying here - if this is a common need then it's
something that's going to be handled in generic code, not open coded in
individual drivers.  Like I say I would expect that you have problems
elsewhere in your code which you are masking with this.