From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Cc: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
alsa-devel@alsa-project.org, Lars-Peter Clausen <lars@metafoo.de>,
Mike Frysinger <vapier@gentoo.org>,
qi.wang@intel.com, Takashi Iwai <tiwai@suse.de>,
linux-kernel@vger.kernel.org, yong.y.wang@intel.com,
kok.howg.ewe@intel.com, Daniel Mack <zonque@gmail.com>,
Liam Girdwood <lrg@ti.com>,
joel.clark@intel.com
Subject: Re: [PATCH 1/3 v5] sound/soc/codecs: add LAPIS Semiconductor ML26124
Date: Thu, 22 Dec 2011 10:50:00 +0000 [thread overview]
Message-ID: <20111222104959.GB4546@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CANKRQngonz+kV3e8tHjvjub-7Pp_5ejqk89Mk7c+Rop9J+_WvA@mail.gmail.com>
On Thu, Dec 22, 2011 at 05:31:08PM +0900, Tomoya MORINAGA wrote:
> 2011/12/20 Mark Brown <broonie@opensource.wolfsonmicro.com>:
> > How have you tested this code?
> No, I haven't tested at all. (Of course, I tested before ASoC.)
> I'll test the new these drivers after you say "Roughly, how to use
> ASoC framework is OK"
Don't do this unless you really have to, and if for some reason it's
needed or useful then indicate that this is what you're doing. People
shouldn't be finding issues on review that mean that the code will never
run. If the testing is very light that's fine but you need to make some
effort to verify that things will work.
next prev parent reply other threads:[~2011-12-22 10:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-20 2:45 [PATCH 1/3 v5] sound/soc/codecs: add LAPIS Semiconductor ML26124 Tomoya MORINAGA
2011-12-20 2:45 ` [PATCH 2/3 v4] sound/soc/lapis: add machine driver for ML7213 Carrier Board Tomoya MORINAGA
2011-12-20 10:45 ` Mark Brown
2011-12-20 2:45 ` [PATCH 3/3 v2] sound/soc/lapis: add platform driver for ML7213 IOH I2S Tomoya MORINAGA
2011-12-20 13:23 ` Mark Brown
2011-12-21 11:22 ` Tomoya MORINAGA
2011-12-22 0:58 ` Mark Brown
2011-12-22 8:10 ` Tomoya MORINAGA
2011-12-22 10:39 ` Mark Brown
2011-12-26 6:33 ` Tomoya MORINAGA
2011-12-26 12:12 ` Mark Brown
2011-12-27 1:25 ` Tomoya MORINAGA
2011-12-27 17:33 ` Mark Brown
2011-12-20 10:40 ` [PATCH 1/3 v5] sound/soc/codecs: add LAPIS Semiconductor ML26124 Mark Brown
2011-12-22 8:31 ` Tomoya MORINAGA
2011-12-22 10:50 ` Mark Brown [this message]
2011-12-20 10:42 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111222104959.GB4546@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=dp@opensource.wolfsonmicro.com \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=qi.wang@intel.com \
--cc=tiwai@suse.de \
--cc=tomoya.rohm@gmail.com \
--cc=vapier@gentoo.org \
--cc=yong.y.wang@intel.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).