alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org,
	David Henningsson <david.henningsson@canonical.com>
Subject: Re: [PATCH] ALSA: hda/jack - Also add jack kctls for Conexant codecs
Date: Thu, 22 Dec 2011 12:21:55 +0000	[thread overview]
Message-ID: <20111222122155.GN4546@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <s5hr4zydm0m.wl%tiwai@suse.de>

On Wed, Dec 21, 2011 at 03:42:17PM +0100, Takashi Iwai wrote:

> Well, the kctl-jack part itself can't break anything right now since
> it's used only in HD-audio.  If others will use, this will be a pure
> addition, so it won't break except for possibly different ctl numids.

A pure addition can still cause problems as we roll out the same
interface into other drivers, for example if there's assumptions that
aren't generally true.

> +void snd_kctl_jack_report(struct snd_card *card,
> +			  struct snd_kcontrol *kctl, bool status)
> +{
> +	if (kctl->private_value == status)
> +		return;
> +	kctl->private_value = status;
> +	snd_ctl_notify(card, SNDRV_CTL_EVENT_MASK_VALUE, &kctl->id);
> +}
> +EXPORT_SYMBOL_GPL(snd_kctl_jack_report);

So, this looks good in so far as it goes but obviously there's no
semantics being defined here for the controls or their names.  That's
more the bit that worries me as we'll get applications starting to use
the new interface and they should have something consistent to work
with.

I'm guessing that as this is just a simple boolean each jack will have a
series of controls like "Headset Jack Headphone" and "Headset Jack
Microphone" or whatever and userspace should match them all together in
the same way that it does for Volume and Switch controls?  That sounds
like it'll work well, we just need to define some strings for standard
jacks and conections.

  parent reply	other threads:[~2011-12-22 12:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-20 14:23 [PATCH] ALSA: hda/jack - Also add jack kctls for Conexant codecs David Henningsson
2011-12-20 14:32 ` Takashi Iwai
2011-12-20 14:44   ` Takashi Iwai
2011-12-20 23:58   ` Mark Brown
2011-12-21 14:42     ` Takashi Iwai
2011-12-22  1:08       ` Mark Brown
2011-12-22 12:21       ` Mark Brown [this message]
2011-12-22 13:55         ` Takashi Iwai
2011-12-22 14:12           ` Mark Brown
2011-12-22 14:19             ` Takashi Iwai
2011-12-22 14:29               ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111222122155.GN4546@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=david.henningsson@canonical.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).