From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Liam Girdwood <lrg@ti.com>, Tony Lindgren <tony@atomide.com>,
Misael Lopez Cruz <misael.lopez@ti.com>,
alsa-devel@alsa-project.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH v2 9/9] ASoC: Kconfig: OMAP4: Enable support for PandaBoards
Date: Thu, 22 Dec 2011 13:26:59 +0000 [thread overview]
Message-ID: <20111222132658.GT4546@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1324557768-8216-10-git-send-email-peter.ujfalusi@ti.com>
On Thu, Dec 22, 2011 at 02:42:48PM +0200, Peter Ujfalusi wrote:
> config SND_OMAP_SOC_OMAP_ABE_TWL6040
> tristate "SoC Audio support for OMAP boards using ABE and twl6040 codec"
> - depends on TWL4030_CORE && SND_OMAP_SOC && MACH_OMAP_4430SDP
> + depends on TWL4030_CORE && SND_OMAP_SOC
> + depends on MACH_OMAP_4430SDP || MACH_OMAP4_PANDA
Given that it's now a platform device and there's a reasonable
expectation that there will be lots of other boards derived from this
it'd seem sensible to just remove the machine dependencies so people
don't have to patch the Kconfig. Otherwise it kind of defeats the point
of making the code generic.
next prev parent reply other threads:[~2011-12-22 13:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 12:42 [PATCH v2 0/9] OMAP4: ASoC: Support for PandaBoard family Peter Ujfalusi
2011-12-22 12:42 ` [PATCH v2 1/9] include: platform_data: Platform data header for OMAP4 ASoC audio Peter Ujfalusi
2011-12-22 13:04 ` Mark Brown
2011-12-22 15:42 ` Liam Girdwood
2011-12-22 17:28 ` Mark Brown
2011-12-22 17:53 ` Girdwood, Liam
2011-12-22 12:42 ` [PATCH v2 2/9] OMAP4: 4430sdp: Register platform device for OMAP4 audio Peter Ujfalusi
2011-12-22 12:42 ` [PATCH v2 3/9] ASoC: omap-abe-twl6040: Convert to platform deriver Peter Ujfalusi
2011-12-22 12:42 ` [PATCH v2 4/9] ASoC: twl6040: Convert MICBIAS to SUPPLY widget Peter Ujfalusi
2011-12-22 14:15 ` Mark Brown
2011-12-22 14:30 ` Peter Ujfalusi
2011-12-22 12:42 ` [PATCH v2 5/9] ASoC: omap-abe-twl6040: Add complete DAPM routing Peter Ujfalusi
2011-12-22 12:42 ` [PATCH v2 6/9] ASoC: omap-abe-twl6040: DAI link selection based on platform data Peter Ujfalusi
2011-12-22 12:42 ` [PATCH v2 7/9] ASoC: omap-abe-twl6040: Configure card according to " Peter Ujfalusi
2011-12-22 13:08 ` Mark Brown
2011-12-22 12:42 ` [PATCH v2 8/9] OMAP4: omap4panda: Enable audio support Peter Ujfalusi
2011-12-22 13:24 ` Mark Brown
2011-12-22 14:14 ` Peter Ujfalusi
2011-12-22 12:42 ` [PATCH v2 9/9] ASoC: Kconfig: OMAP4: Enable support for PandaBoards Peter Ujfalusi
2011-12-22 13:26 ` Mark Brown [this message]
2011-12-22 14:11 ` Peter Ujfalusi
-- strict thread matches above, loose matches on Subject: below --
2011-12-22 16:38 [PATCH v2 0/9] OMAP4: ASoC: Support for PandaBoard family Peter Ujfalusi
2011-12-22 16:38 ` [PATCH v2 9/9] ASoC: Kconfig: OMAP4: Enable support for PandaBoards Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111222132658.GT4546@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=misael.lopez@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).